diff options
| author | Thomas Huth <thuth@redhat.com> | 2024-05-17 08:15:53 +0200 |
|---|---|---|
| committer | Thomas Huth <thuth@redhat.com> | 2024-05-17 11:18:32 +0200 |
| commit | bebe9603fcb072dcdb7fb22005781b3582a4d701 (patch) | |
| tree | f2f57ffc416dabe59475d84f7dcd67076d663228 /hw | |
| parent | e4b6adae7aa7ab440e4dd98de3c1c532f48eda60 (diff) | |
| download | qemu-bebe9603fcb072dcdb7fb22005781b3582a4d701.zip qemu-bebe9603fcb072dcdb7fb22005781b3582a4d701.tar.gz qemu-bebe9603fcb072dcdb7fb22005781b3582a4d701.tar.bz2 | |
hw/intc/s390_flic: Fix crash that occurs when saving the machine state
adapter_info_so_needed() treats its "opaque" parameter as a S390FLICState,
but the function belongs to a VMStateDescription that is attached to a
TYPE_VIRTIO_CCW_BUS device. This is currently causing a crash when the
user tries to save or migrate the VM state. Fix it by using s390_get_flic()
to get the correct device here instead.
Reported-by: Marc Hartmayer <mhartmay@linux.ibm.com>
Fixes: 9d1b0f5bf5 ("s390_flic: add migration-enabled property")
Message-ID: <20240517061553.564529-1-thuth@redhat.com>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Tested-by: Marc Hartmayer <mhartmay@linux.ibm.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
Diffstat (limited to 'hw')
| -rw-r--r-- | hw/intc/s390_flic.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/hw/intc/s390_flic.c b/hw/intc/s390_flic.c index 7f93080..6771645 100644 --- a/hw/intc/s390_flic.c +++ b/hw/intc/s390_flic.c @@ -459,7 +459,7 @@ type_init(qemu_s390_flic_register_types) static bool adapter_info_so_needed(void *opaque) { - S390FLICState *fs = S390_FLIC_COMMON(opaque); + S390FLICState *fs = s390_get_flic(); return fs->migration_enabled; } |