diff options
| author | Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru> | 2022-11-17 00:44:58 +0300 |
|---|---|---|
| committer | Michael S. Tsirkin <mst@redhat.com> | 2023-01-27 09:48:49 -0500 |
| commit | 9ce75d4d5eaf30333797fd6f8b5c6ee7f917951f (patch) | |
| tree | 0ea5cb8817bbfa44dd8708dbf11f9e37bcf5e67d /hw | |
| parent | 13356edb87506c148b163b8c7eb0695647d00c2a (diff) | |
| download | qemu-9ce75d4d5eaf30333797fd6f8b5c6ee7f917951f.zip qemu-9ce75d4d5eaf30333797fd6f8b5c6ee7f917951f.tar.gz qemu-9ce75d4d5eaf30333797fd6f8b5c6ee7f917951f.tar.bz2 | |
shpc: disallow unplug when power indicator is blinking
Pressing attention button has special meaning when power indicator is
blinking. Better just not do it.
For example, trying to remove device immediately after hotplug leads to
both commands succeded but device not actually unrealized.
Same thing for PCIE hotplug was done in
81124b3c7a5dae "pcie: add power indicator blink check"
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Message-Id: <20221116214458.82090-1-vsementsov@yandex-team.ru>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Diffstat (limited to 'hw')
| -rw-r--r-- | hw/pci/shpc.c | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/hw/pci/shpc.c b/hw/pci/shpc.c index e71f3a7..fca7f66 100644 --- a/hw/pci/shpc.c +++ b/hw/pci/shpc.c @@ -568,6 +568,13 @@ void shpc_device_unplug_request_cb(HotplugHandler *hotplug_dev, state = shpc_get_status(shpc, slot, SHPC_SLOT_STATE_MASK); led = shpc_get_status(shpc, slot, SHPC_SLOT_PWR_LED_MASK); + + if (led == SHPC_LED_BLINK) { + error_setg(errp, "Hot-unplug failed: " + "guest is busy (power indicator blinking)"); + return; + } + if (state == SHPC_STATE_DISABLED && led == SHPC_LED_OFF) { shpc_free_devices_in_slot(shpc, slot); shpc_set_status(shpc, slot, 1, SHPC_SLOT_STATUS_MRL_OPEN); |