aboutsummaryrefslogtreecommitdiff
path: root/hw
diff options
context:
space:
mode:
authorEduardo Habkost <ehabkost@redhat.com>2017-05-03 17:35:47 -0300
committerEduardo Habkost <ehabkost@redhat.com>2017-05-17 10:37:01 -0300
commit8ab5700ca07428d62a3e75c2c15aa7dc3e962b44 (patch)
tree5c41229c026754c0f8674dbfb0260527e05f89fe /hw
parent950b31dd17fccc42ecddc9528408b00a20c9be3c (diff)
downloadqemu-8ab5700ca07428d62a3e75c2c15aa7dc3e962b44.zip
qemu-8ab5700ca07428d62a3e75c2c15aa7dc3e962b44.tar.gz
qemu-8ab5700ca07428d62a3e75c2c15aa7dc3e962b44.tar.bz2
iommu: Remove FIXME comment about user_creatable=true
amd-iommu and intel-iommu are really meant to be used with -device, so they need user_creatable=true. Remove the FIXME comment. Cc: Marcel Apfelbaum <marcel@redhat.com> Cc: "Michael S. Tsirkin" <mst@redhat.com> Reviewed-by: Marcel Apfelbaum <marcel@redhat.com> Acked-by: Marcel Apfelbaum <marcel@redhat.com> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com> Message-Id: <20170503203604.31462-5-ehabkost@redhat.com> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Diffstat (limited to 'hw')
-rw-r--r--hw/i386/amd_iommu.c5
-rw-r--r--hw/i386/intel_iommu.c5
2 files changed, 2 insertions, 8 deletions
diff --git a/hw/i386/amd_iommu.c b/hw/i386/amd_iommu.c
index 7b92c8c..efcc93c 100644
--- a/hw/i386/amd_iommu.c
+++ b/hw/i386/amd_iommu.c
@@ -1186,10 +1186,7 @@ static void amdvi_class_init(ObjectClass *klass, void* data)
dc->vmsd = &vmstate_amdvi;
dc->hotpluggable = false;
dc_class->realize = amdvi_realize;
- /*
- * FIXME: Set only because we are not sure yet if this device
- * will be outside the q35 sysbus whitelist.
- */
+ /* Supported by the pc-q35-* machine types */
dc->user_creatable = true;
}
diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c
index 54187a0..327a46c 100644
--- a/hw/i386/intel_iommu.c
+++ b/hw/i386/intel_iommu.c
@@ -3009,10 +3009,7 @@ static void vtd_class_init(ObjectClass *klass, void *data)
dc->hotpluggable = false;
x86_class->realize = vtd_realize;
x86_class->int_remap = vtd_int_remap;
- /*
- * FIXME: Set only because we are not sure yet if this device
- * will be outside the q35 sysbus whitelist.
- */
+ /* Supported by the pc-q35-* machine types */
dc->user_creatable = true;
}