aboutsummaryrefslogtreecommitdiff
path: root/hw
diff options
context:
space:
mode:
authorPaolo Bonzini <pbonzini@redhat.com>2018-03-05 09:18:26 +0100
committerPaolo Bonzini <pbonzini@redhat.com>2018-03-06 14:01:27 +0100
commit80d2b933f9fe3e53d4f76a45a1bc1a0175669468 (patch)
tree5f6ac8fa6bf593b82182c38e9c7c8ba87f0a43c0 /hw
parent8b2ec54ff39c319dcb12e430d9e69d081395b964 (diff)
downloadqemu-80d2b933f9fe3e53d4f76a45a1bc1a0175669468.zip
qemu-80d2b933f9fe3e53d4f76a45a1bc1a0175669468.tar.gz
qemu-80d2b933f9fe3e53d4f76a45a1bc1a0175669468.tar.bz2
openpic_kvm: drop address_space_to_flatview call
The MemoryListener is registered on address_space_memory, there is not much to assert. This currently works because the callback is invoked only once when the listener is registered, but section->fv is the _new_ FlatView, not the old one on later calls and that would break. This confines address_space_to_flatview to exec.c and memory.c. Acked-by: David Gibson <david@gibson.dropbear.id.au> Reviewed-by: Alexey Kardashevskiy <aik@ozlabs.ru> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Diffstat (limited to 'hw')
-rw-r--r--hw/intc/openpic_kvm.c4
1 files changed, 0 insertions, 4 deletions
diff --git a/hw/intc/openpic_kvm.c b/hw/intc/openpic_kvm.c
index f1a59e5..928bc04 100644
--- a/hw/intc/openpic_kvm.c
+++ b/hw/intc/openpic_kvm.c
@@ -125,10 +125,6 @@ static void kvm_openpic_region_add(MemoryListener *listener,
uint64_t reg_base;
int ret;
- if (section->fv != address_space_to_flatview(&address_space_memory)) {
- abort();
- }
-
/* Ignore events on regions that are not us */
if (section->mr != &opp->mem) {
return;