diff options
| author | Greg Kurz <groug@kaod.org> | 2020-02-12 19:54:00 +0100 |
|---|---|---|
| committer | David Gibson <david@gibson.dropbear.id.au> | 2020-02-21 09:15:04 +1100 |
| commit | 5a205fcf7700abe442b374d76a8c4edea92eecc7 (patch) | |
| tree | 41ebd800984eb43329e7eba51ceaacc0b0af5b17 /hw | |
| parent | 19b5c4186eccc519e6906838b288b2e206d43efe (diff) | |
| download | qemu-5a205fcf7700abe442b374d76a8c4edea92eecc7.zip qemu-5a205fcf7700abe442b374d76a8c4edea92eecc7.tar.gz qemu-5a205fcf7700abe442b374d76a8c4edea92eecc7.tar.bz2 | |
pnv/phb3: Convert 1u to 1ull
As reported by Coverity defect CID 1419397, the 'j' variable goes up to
63 and shouldn't be used to left shift a 32-bit integer.
The result of the operation goes to a 64-bit integer : use a 64-bit
constant.
Reported-by: Coverity CID 1419397 Bad bit shift operation
Fixes: 9ae1329ee2fe "ppc/pnv: Add models for POWER8 PHB3 PCIe Host bridge"
Signed-off-by: Greg Kurz <groug@kaod.org>
Message-Id: <158153364010.3229002.8004283672455615950.stgit@bahia.lan>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Diffstat (limited to 'hw')
| -rw-r--r-- | hw/pci-host/pnv_phb3_msi.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/hw/pci-host/pnv_phb3_msi.c b/hw/pci-host/pnv_phb3_msi.c index ecfc1b2..d645468 100644 --- a/hw/pci-host/pnv_phb3_msi.c +++ b/hw/pci-host/pnv_phb3_msi.c @@ -220,7 +220,7 @@ static void phb3_msi_resend(ICSState *ics) if ((msi->rba[i] & (1ull << j)) == 0) { continue; } - msi->rba[i] &= ~(1u << j); + msi->rba[i] &= ~(1ull << j); phb3_msi_try_send(msi, i * 64 + j, true); } } |