aboutsummaryrefslogtreecommitdiff
path: root/hw
diff options
context:
space:
mode:
authorJason Wang <jasowang@redhat.com>2021-04-02 11:03:33 +0800
committerJason Wang <jasowang@redhat.com>2021-04-08 17:33:59 +0800
commit56e6f594bf47a0a543ff5e6d14701355fe99b098 (patch)
tree0b3ee5f7b43fde16795a00537796a87f0289d020 /hw
parent603f2f7c6c8c747d0189936a74fb33e610ce7858 (diff)
downloadqemu-56e6f594bf47a0a543ff5e6d14701355fe99b098.zip
qemu-56e6f594bf47a0a543ff5e6d14701355fe99b098.tar.gz
qemu-56e6f594bf47a0a543ff5e6d14701355fe99b098.tar.bz2
Revert "net: Move NetClientState.info_str to dynamic allocations"
Several issues has been reported for query-netdev info series. Consider it's late in the rc, this reverts commit commit 59b5437eb732d6b103a9bc279c3482c834d1eff9. Signed-off-by: Jason Wang <jasowang@redhat.com>
Diffstat (limited to 'hw')
-rw-r--r--hw/net/xen_nic.c5
1 files changed, 3 insertions, 2 deletions
diff --git a/hw/net/xen_nic.c b/hw/net/xen_nic.c
index 8431808..5c815b4 100644
--- a/hw/net/xen_nic.c
+++ b/hw/net/xen_nic.c
@@ -296,8 +296,9 @@ static int net_init(struct XenLegacyDevice *xendev)
netdev->nic = qemu_new_nic(&net_xen_info, &netdev->conf,
"xen", NULL, netdev);
- qemu_get_queue(netdev->nic)->info_str = g_strdup_printf(
- "nic: xenbus vif macaddr=%s", netdev->mac);
+ snprintf(qemu_get_queue(netdev->nic)->info_str,
+ sizeof(qemu_get_queue(netdev->nic)->info_str),
+ "nic: xenbus vif macaddr=%s", netdev->mac);
/* fill info */
xenstore_write_be_int(&netdev->xendev, "feature-rx-copy", 1);