aboutsummaryrefslogtreecommitdiff
path: root/hw
diff options
context:
space:
mode:
authorPeter Maydell <peter.maydell@linaro.org>2017-01-16 18:46:00 +0000
committerMichael Tokarev <mjt@tls.msk.ru>2017-01-24 23:26:53 +0300
commit4f04560ba93f179151d90b0e6c6c53235fe1a279 (patch)
tree072d777c54d7bc5781b33487f43a8572792ba11a /hw
parent87eb2bac6a54c74e9e0bfcb69cf8e93727af04f9 (diff)
downloadqemu-4f04560ba93f179151d90b0e6c6c53235fe1a279.zip
qemu-4f04560ba93f179151d90b0e6c6c53235fe1a279.tar.gz
qemu-4f04560ba93f179151d90b0e6c6c53235fe1a279.tar.bz2
scsi-disk: add 'fall through' comment to switch VERIFY cases
Commit 166dbda7e131 added some extra cases to a switch() such that the existing code is intended to fall through the new case statements. It's clear from the commit that this is intentional, but less clear to subsequent readers of the code, and not clear at all to static analysis tools like Coverity. Add a /* fall through */ comment to indicate the intent. (Fixes CID 1368287.) Signed-off-by: Peter Maydell <peter.maydell@linaro.org> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
Diffstat (limited to 'hw')
-rw-r--r--hw/scsi/scsi-disk.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c
index c080888..cc06fe5 100644
--- a/hw/scsi/scsi-disk.c
+++ b/hw/scsi/scsi-disk.c
@@ -2157,6 +2157,7 @@ static int32_t scsi_disk_dma_command(SCSIRequest *req, uint8_t *buf)
DPRINTF("Write %s(sector %" PRId64 ", count %u)\n",
(command & 0xe) == 0xe ? "And Verify " : "",
r->req.cmd.lba, len);
+ /* fall through */
case VERIFY_10:
case VERIFY_12:
case VERIFY_16: