diff options
| author | Peter Maydell <peter.maydell@linaro.org> | 2022-01-22 18:24:34 +0000 |
|---|---|---|
| committer | Peter Maydell <peter.maydell@linaro.org> | 2022-01-28 14:29:47 +0000 |
| commit | 1e794a3be1687a8561c7188a3d3fc26f525cf487 (patch) | |
| tree | 410f0a4a3d97a43e486e3b8d0c9feece8d773a81 /hw | |
| parent | e5ff041f62fd01154dc91f9ac43ac3498b4689e1 (diff) | |
| download | qemu-1e794a3be1687a8561c7188a3d3fc26f525cf487.zip qemu-1e794a3be1687a8561c7188a3d3fc26f525cf487.tar.gz qemu-1e794a3be1687a8561c7188a3d3fc26f525cf487.tar.bz2 | |
hw/intc/arm_gicv3_its: Don't clear GITS_CREADR when GITS_CTLR.ENABLED is set
The current ITS code clears GITS_CREADR when GITS_CTLR.ENABLED is set.
This is not correct -- guest code can validly clear ENABLED and then
set it again and expect the ITS to continue processing where it left
off. Remove the erroneous assignment.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-id: 20220122182444.724087-5-peter.maydell@linaro.org
Diffstat (limited to 'hw')
| -rw-r--r-- | hw/intc/arm_gicv3_its.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/hw/intc/arm_gicv3_its.c b/hw/intc/arm_gicv3_its.c index 67f12d9..1763ba4 100644 --- a/hw/intc/arm_gicv3_its.c +++ b/hw/intc/arm_gicv3_its.c @@ -853,7 +853,6 @@ static bool its_writel(GICv3ITSState *s, hwaddr offset, s->ctlr |= R_GITS_CTLR_ENABLED_MASK; extract_table_params(s); extract_cmdq_params(s); - s->creadr = 0; process_cmdq(s); } else { s->ctlr &= ~R_GITS_CTLR_ENABLED_MASK; |