diff options
| author | Peter Maydell <peter.maydell@linaro.org> | 2015-11-25 11:38:03 +0000 |
|---|---|---|
| committer | Peter Maydell <peter.maydell@linaro.org> | 2015-11-25 11:38:03 +0000 |
| commit | 1aae36df4b8ed884c6ef6995e70c67fad79b49df (patch) | |
| tree | 059f6801255605ff19fbc616c19a2e2a6abb1b5f /hw | |
| parent | 4b6eda626fdb8bf90472c6868d502a2ac09abeeb (diff) | |
| parent | 1d649244b3695cb148dd2ae66999db0f6f9566b3 (diff) | |
| download | qemu-1aae36df4b8ed884c6ef6995e70c67fad79b49df.zip qemu-1aae36df4b8ed884c6ef6995e70c67fad79b49df.tar.gz qemu-1aae36df4b8ed884c6ef6995e70c67fad79b49df.tar.bz2 | |
Merge remote-tracking branch 'remotes/armbru/tags/pull-ivshmem-2015-11-25' into staging
ivshmem patches for 2.5
# gpg: Signature made Wed 25 Nov 2015 09:25:38 GMT using RSA key ID EB918653
# gpg: Good signature from "Markus Armbruster <armbru@redhat.com>"
# gpg: aka "Markus Armbruster <armbru@pond.sub.org>"
* remotes/armbru/tags/pull-ivshmem-2015-11-25:
ivshmem: Rename property memdev to x-memdev for 2.5
ivshmem: Mark questionable socket type test FIXME
tests/ivshmem-test: Supply missing initializer in get_device()
qemu-doc: Fix ivshmem usage example with shm=...
qemu-doc: Fix ivshmem example markup
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Diffstat (limited to 'hw')
| -rw-r--r-- | hw/misc/ivshmem.c | 9 |
1 files changed, 4 insertions, 5 deletions
diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c index 83d7bd3..f73f0c2 100644 --- a/hw/misc/ivshmem.c +++ b/hw/misc/ivshmem.c @@ -60,8 +60,6 @@ #define IVSHMEM(obj) \ OBJECT_CHECK(IVShmemState, (obj), TYPE_IVSHMEM) -#define IVSHMEM_MEMDEV_PROP "memdev" - typedef struct Peer { int nb_eventfds; EventNotifier *eventfds; @@ -857,8 +855,8 @@ static void pci_ivshmem_realize(PCIDevice *dev, Error **errp) PCI_BASE_ADDRESS_MEM_PREFETCH; if (!!s->server_chr + !!s->shmobj + !!s->hostmem != 1) { - error_setg(errp, "You must specify either a shmobj, a chardev" - " or a hostmem"); + error_setg(errp, + "You must specify either 'shm', 'chardev' or 'x-memdev'"); return; } @@ -939,6 +937,7 @@ static void pci_ivshmem_realize(PCIDevice *dev, Error **errp) memory_region_add_subregion(&s->bar, 0, mr); pci_register_bar(PCI_DEVICE(s), 2, attr, &s->bar); } else if (s->server_chr != NULL) { + /* FIXME do not rely on what chr drivers put into filename */ if (strncmp(s->server_chr->filename, "unix:", 5)) { error_setg(errp, "chardev is not a unix client socket"); return; @@ -1181,7 +1180,7 @@ static void ivshmem_init(Object *obj) { IVShmemState *s = IVSHMEM(obj); - object_property_add_link(obj, IVSHMEM_MEMDEV_PROP, TYPE_MEMORY_BACKEND, + object_property_add_link(obj, "x-memdev", TYPE_MEMORY_BACKEND, (Object **)&s->hostmem, ivshmem_check_memdev_is_busy, OBJ_PROP_LINK_UNREF_ON_RELEASE, |