diff options
| author | Greg Kurz <groug@kaod.org> | 2020-10-29 16:33:48 +0100 |
|---|---|---|
| committer | David Gibson <david@gibson.dropbear.id.au> | 2020-11-05 12:18:48 +1100 |
| commit | 184b813e7b1fe2dc27e7657befc907b5aac3b619 (patch) | |
| tree | 4d5ffd7e1d631faaf108ffaee65b367c3ba47afa /hw | |
| parent | 295397f53cc1e337e5c1ada62a9ac9feea4d4e97 (diff) | |
| download | qemu-184b813e7b1fe2dc27e7657befc907b5aac3b619.zip qemu-184b813e7b1fe2dc27e7657befc907b5aac3b619.tar.gz qemu-184b813e7b1fe2dc27e7657befc907b5aac3b619.tar.bz2 | |
spapr: Drop dead code in spapr_reallocate_hpt()
Sometimes QEMU needs to allocate the HPT in userspace, namely with TCG
or PR KVM. This is performed with qemu_memalign() because of alignment
requirements. Like glib's allocators, its behaviour is to abort on OOM
instead of returning NULL.
This could be changed to qemu_try_memalign(), but in the specific case
of spapr_reallocate_hpt(), the outcome would be to terminate QEMU anyway
since no HPT means no MMU for the guest. Drop the dead code instead.
Signed-off-by: Greg Kurz <groug@kaod.org>
Message-Id: <160398562892.32380.15006707861753544263.stgit@bahia.lan>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Diffstat (limited to 'hw')
| -rw-r--r-- | hw/ppc/spapr.c | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index 2270751..12a012d 100644 --- a/hw/ppc/spapr.c +++ b/hw/ppc/spapr.c @@ -1522,12 +1522,6 @@ int spapr_reallocate_hpt(SpaprMachineState *spapr, int shift, Error **errp) int i; spapr->htab = qemu_memalign(size, size); - if (!spapr->htab) { - error_setg_errno(errp, errno, - "Could not allocate HPT of order %d", shift); - return -ENOMEM; - } - memset(spapr->htab, 0, size); spapr->htab_shift = shift; |