diff options
| author | Philippe Mathieu-Daudé <philmd@linaro.org> | 2023-10-03 09:58:14 +0200 |
|---|---|---|
| committer | Philippe Mathieu-Daudé <philmd@linaro.org> | 2023-10-19 23:13:28 +0200 |
| commit | 0459c141f8d9dc99274ca3cffe632a37a0575c9e (patch) | |
| tree | 53791a8a3f8d8b6037baf60fcc0bd68d0befbb56 /hw | |
| parent | b2b5b09045e61798d5454f6b32721172d736c828 (diff) | |
| download | qemu-0459c141f8d9dc99274ca3cffe632a37a0575c9e.zip qemu-0459c141f8d9dc99274ca3cffe632a37a0575c9e.tar.gz qemu-0459c141f8d9dc99274ca3cffe632a37a0575c9e.tar.bz2 | |
hw/intc/apic: Use ERRP_GUARD() in apic_common_realize()
APICCommonClass::realize() is a DeviceRealize() handler which
take an Error** parameter and can fail. Do not proceed further
on failure.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Peter Xu <peterx@redhat.com>
Message-Id: <20231003082728.83496-2-philmd@linaro.org>
Diffstat (limited to 'hw')
| -rw-r--r-- | hw/intc/apic_common.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/hw/intc/apic_common.c b/hw/intc/apic_common.c index 68ad30e..bccb424 100644 --- a/hw/intc/apic_common.c +++ b/hw/intc/apic_common.c @@ -257,6 +257,7 @@ static const VMStateDescription vmstate_apic_common; static void apic_common_realize(DeviceState *dev, Error **errp) { + ERRP_GUARD(); APICCommonState *s = APIC_COMMON(dev); APICCommonClass *info; static DeviceState *vapic; @@ -267,6 +268,9 @@ static void apic_common_realize(DeviceState *dev, Error **errp) info = APIC_COMMON_GET_CLASS(s); info->realize(dev, errp); + if (*errp) { + return; + } /* Note: We need at least 1M to map the VAPIC option ROM */ if (!vapic && s->vapic_control & VAPIC_ENABLE_MASK && |