diff options
| author | Markus Armbruster <armbru@redhat.com> | 2019-08-12 07:23:51 +0200 |
|---|---|---|
| committer | Markus Armbruster <armbru@redhat.com> | 2019-08-16 13:31:53 +0200 |
| commit | a27bd6c779badb8d76e4430d810ef710a1b98f4e (patch) | |
| tree | b7631b26b400537ff383b13e9e9deb299cef85b4 /hw/vfio | |
| parent | db725815985654007ade0fd53590d613fd657208 (diff) | |
| download | qemu-a27bd6c779badb8d76e4430d810ef710a1b98f4e.zip qemu-a27bd6c779badb8d76e4430d810ef710a1b98f4e.tar.gz qemu-a27bd6c779badb8d76e4430d810ef710a1b98f4e.tar.bz2 | |
Include hw/qdev-properties.h less
In my "build everything" tree, changing hw/qdev-properties.h triggers
a recompile of some 2700 out of 6600 objects (not counting tests and
objects that don't depend on qemu/osdep.h).
Many places including hw/qdev-properties.h (directly or via hw/qdev.h)
actually need only hw/qdev-core.h. Include hw/qdev-core.h there
instead.
hw/qdev.h is actually pointless: all it does is include hw/qdev-core.h
and hw/qdev-properties.h, which in turn includes hw/qdev-core.h.
Replace the remaining uses of hw/qdev.h by hw/qdev-properties.h.
While there, delete a few superfluous inclusions of hw/qdev-core.h.
Touching hw/qdev-properties.h now recompiles some 1200 objects.
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: Eduardo Habkost <ehabkost@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
Message-Id: <20190812052359.30071-22-armbru@redhat.com>
Diffstat (limited to 'hw/vfio')
| -rw-r--r-- | hw/vfio/ap.c | 1 | ||||
| -rw-r--r-- | hw/vfio/ccw.c | 1 | ||||
| -rw-r--r-- | hw/vfio/pci-quirks.c | 1 | ||||
| -rw-r--r-- | hw/vfio/pci.c | 1 | ||||
| -rw-r--r-- | hw/vfio/platform.c | 1 |
5 files changed, 5 insertions, 0 deletions
diff --git a/hw/vfio/ap.c b/hw/vfio/ap.c index 2bfc402..d53453a 100644 --- a/hw/vfio/ap.c +++ b/hw/vfio/ap.c @@ -26,6 +26,7 @@ #include "kvm_s390x.h" #include "migration/vmstate.h" #include "sysemu/sysemu.h" +#include "hw/qdev-properties.h" #include "hw/s390x/ap-bridge.h" #include "exec/address-spaces.h" diff --git a/hw/vfio/ccw.c b/hw/vfio/ccw.c index c78a85a..6863f6c 100644 --- a/hw/vfio/ccw.c +++ b/hw/vfio/ccw.c @@ -25,6 +25,7 @@ #include "hw/vfio/vfio-common.h" #include "hw/s390x/s390-ccw.h" #include "hw/s390x/vfio-ccw.h" +#include "hw/qdev-properties.h" #include "hw/s390x/ccw-device.h" #include "exec/address-spaces.h" #include "qemu/error-report.h" diff --git a/hw/vfio/pci-quirks.c b/hw/vfio/pci-quirks.c index 62d765a..f71aace 100644 --- a/hw/vfio/pci-quirks.c +++ b/hw/vfio/pci-quirks.c @@ -21,6 +21,7 @@ #include <sys/ioctl.h> #include "hw/hw.h" #include "hw/nvram/fw_cfg.h" +#include "hw/qdev-properties.h" #include "pci.h" #include "trace.h" diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c index ab3ee2c..8337af8 100644 --- a/hw/vfio/pci.c +++ b/hw/vfio/pci.c @@ -26,6 +26,7 @@ #include "hw/pci/msi.h" #include "hw/pci/msix.h" #include "hw/pci/pci_bridge.h" +#include "hw/qdev-properties.h" #include "migration/vmstate.h" #include "qemu/error-report.h" #include "qemu/main-loop.h" diff --git a/hw/vfio/platform.c b/hw/vfio/platform.c index ff5f805..d14f6b4 100644 --- a/hw/vfio/platform.c +++ b/hw/vfio/platform.c @@ -33,6 +33,7 @@ #include "trace.h" #include "hw/irq.h" #include "hw/platform-bus.h" +#include "hw/qdev-properties.h" #include "sysemu/kvm.h" /* |