diff options
| author | Alex Williamson <alex.williamson@redhat.com> | 2018-08-23 10:45:57 -0600 |
|---|---|---|
| committer | Alex Williamson <alex.williamson@redhat.com> | 2018-08-23 10:45:57 -0600 |
| commit | a1c0f886496cfb4c336f8eb4155ed424567d653e (patch) | |
| tree | 3513a6ca6bb3831e4508fca9c41d3e3f2ccfa32a /hw/vfio | |
| parent | 3392fbee4e435658733bbe9aab23392660558b59 (diff) | |
| download | qemu-a1c0f886496cfb4c336f8eb4155ed424567d653e.zip qemu-a1c0f886496cfb4c336f8eb4155ed424567d653e.tar.gz qemu-a1c0f886496cfb4c336f8eb4155ed424567d653e.tar.bz2 | |
vfio/pci: Handle subsystem realpath() returning NULL
Fix error reported by Coverity where realpath can return NULL,
resulting in a segfault in strcmp(). This should never happen given
that we're working through regularly structured sysfs paths, but
trivial enough to easily avoid.
Fixes: 238e91728503 ("vfio/ccw/pci: Allow devices to opt-in for ballooning")
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
Diffstat (limited to 'hw/vfio')
| -rw-r--r-- | hw/vfio/pci.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c index 056f3a8..866f0de 100644 --- a/hw/vfio/pci.c +++ b/hw/vfio/pci.c @@ -2879,7 +2879,7 @@ static void vfio_realize(PCIDevice *pdev, Error **errp) tmp = g_strdup_printf("%s/subsystem", vdev->vbasedev.sysfsdev); subsys = realpath(tmp, NULL); g_free(tmp); - is_mdev = (strcmp(subsys, "/sys/bus/mdev") == 0); + is_mdev = subsys && (strcmp(subsys, "/sys/bus/mdev") == 0); free(subsys); trace_vfio_mdev(vdev->vbasedev.name, is_mdev); |