diff options
| author | Cédric Le Goater <clg@redhat.com> | 2025-02-06 14:14:34 +0100 |
|---|---|---|
| committer | Cédric Le Goater <clg@redhat.com> | 2025-02-11 14:15:19 +0100 |
| commit | 889695f8f3c10647cc27a3788b4a3f1d0192926c (patch) | |
| tree | af6c7c9a3e03b9a30e0a6d2e138a70d26f7eef41 /hw/vfio | |
| parent | aaec00422ba6538ca3e6bfa612bbae155ec15c84 (diff) | |
| download | qemu-889695f8f3c10647cc27a3788b4a3f1d0192926c.zip qemu-889695f8f3c10647cc27a3788b4a3f1d0192926c.tar.gz qemu-889695f8f3c10647cc27a3788b4a3f1d0192926c.tar.bz2 | |
vfio: Remove reports of DMA mapping errors in backends
Currently, the mapping handlers of the IOMMU backends, VFIO IOMMU Type
1 aka. legacy and IOMMUFD, return an errno and also report an error.
This can lead to excessive log messages at runtime for recurring DMA
mapping errors. Since these errors are already reported by the callers
in the vfio_container_dma_un/map() routines, simply remove them and
allow the callers to handle the reporting.
The mapping handler of the IOMMUFD backend has a comment suggesting
MMIO region mapping failures return EFAULT. I am not sure this is
entirely true, so keep the EFAULT case until the conditions are
clarified.
Reviewed-by: Alex Williamson <alex.williamson@redhat.com>
Link: https://lore.kernel.org/qemu-devel/20250206131438.1505542-7-clg@redhat.com
Signed-off-by: Cédric Le Goater <clg@redhat.com>
Diffstat (limited to 'hw/vfio')
| -rw-r--r-- | hw/vfio/container.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/hw/vfio/container.c b/hw/vfio/container.c index 4ebb526..7c57bdd2 100644 --- a/hw/vfio/container.c +++ b/hw/vfio/container.c @@ -159,7 +159,6 @@ static int vfio_legacy_dma_unmap(const VFIOContainerBase *bcontainer, unmap.size -= 1ULL << ctz64(bcontainer->pgsizes); continue; } - error_report("VFIO_UNMAP_DMA failed: %s", strerror(errno)); return -errno; } @@ -204,7 +203,6 @@ static int vfio_legacy_dma_map(const VFIOContainerBase *bcontainer, hwaddr iova, return 0; } - error_report("VFIO_MAP_DMA failed: %s", strerror(errno)); return -errno; } |