diff options
| author | Chen Qun <kuhn.chenqun@huawei.com> | 2020-02-26 16:46:46 +0800 |
|---|---|---|
| committer | Gerd Hoffmann <kraxel@redhat.com> | 2020-03-09 11:12:55 +0100 |
| commit | e13a22db0d47012e19ad02c9dafacbe25f94e1b4 (patch) | |
| tree | 33391fcd7daab23cacdf2bdbeebb01eb332e86af /hw/usb | |
| parent | 5843b6b35250139d91220ac3b75d467703e345b3 (diff) | |
| download | qemu-e13a22db0d47012e19ad02c9dafacbe25f94e1b4.zip qemu-e13a22db0d47012e19ad02c9dafacbe25f94e1b4.tar.gz qemu-e13a22db0d47012e19ad02c9dafacbe25f94e1b4.tar.bz2 | |
usb/hcd-ehci: Remove redundant statements
The "again" assignment is meaningless before g_assert_not_reached.
In addition, the break statements no longer needs to be after
g_assert_not_reached.
Clang static code analyzer show warning:
hw/usb/hcd-ehci.c:2108:13: warning: Value stored to 'again' is never read
again = -1;
^ ~~
Reported-by: Euler Robot <euler.robot@huawei.com>
Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20200226084647.20636-13-kuhn.chenqun@huawei.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Diffstat (limited to 'hw/usb')
| -rw-r--r-- | hw/usb/hcd-ehci.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c index 56ab2f4..29d49c2 100644 --- a/hw/usb/hcd-ehci.c +++ b/hw/usb/hcd-ehci.c @@ -1301,7 +1301,6 @@ static void ehci_execute_complete(EHCIQueue *q) /* should not be triggerable */ fprintf(stderr, "USB invalid response %d\n", p->packet.status); g_assert_not_reached(); - break; } /* TODO check 4.12 for splits */ @@ -2105,9 +2104,7 @@ static void ehci_advance_state(EHCIState *ehci, int async) default: fprintf(stderr, "Bad state!\n"); - again = -1; g_assert_not_reached(); - break; } if (again < 0 || itd_count > 16) { |