aboutsummaryrefslogtreecommitdiff
path: root/hw/usb
diff options
context:
space:
mode:
authorVijay Kumar B <vijaykumar@zilogic.com>2016-09-28 16:39:18 +0530
committerGerd Hoffmann <kraxel@redhat.com>2016-10-12 14:37:15 +0200
commit6998b6c7c77e22d386fb8792365e668351d22f91 (patch)
tree7b119244fb3df404cdf4a95d0dfd0c16d8d128cf /hw/usb
parent0136464d10f1fd9393a8125f2c552ef24f3e592c (diff)
downloadqemu-6998b6c7c77e22d386fb8792365e668351d22f91.zip
qemu-6998b6c7c77e22d386fb8792365e668351d22f91.tar.gz
qemu-6998b6c7c77e22d386fb8792365e668351d22f91.tar.bz2
usb: Fix incorrect default DMA offset.
The default DMA offset is set to 3. When the property is not set by the consumer, the default causes DMA access to be shifted by 3 bytes. In PXA, this results in incorrect DMA access, leading to error notification in the USB controller driver. A better default would be 0, so that there is no offset, when the consumer does not specify one. Signed-off-by: Vijay Kumar B. <vijaykumar@zilogic.com> Reviewed-by: Deepak S. <deepak@zilogic.com> Message-id: 1475060958-7760-1-git-send-email-vijaykumar@zilogic.com Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Diffstat (limited to 'hw/usb')
-rw-r--r--hw/usb/hcd-ohci.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/hw/usb/hcd-ohci.c b/hw/usb/hcd-ohci.c
index fa57038..c82a92f 100644
--- a/hw/usb/hcd-ohci.c
+++ b/hw/usb/hcd-ohci.c
@@ -2139,7 +2139,7 @@ static const TypeInfo ohci_pci_info = {
static Property ohci_sysbus_properties[] = {
DEFINE_PROP_UINT32("num-ports", OHCISysBusState, num_ports, 3),
- DEFINE_PROP_DMAADDR("dma-offset", OHCISysBusState, dma_offset, 3),
+ DEFINE_PROP_DMAADDR("dma-offset", OHCISysBusState, dma_offset, 0),
DEFINE_PROP_END_OF_LIST(),
};