diff options
| author | Igor Mammedov <imammedo@redhat.com> | 2024-03-26 13:26:30 +0100 |
|---|---|---|
| committer | Philippe Mathieu-Daudé <philmd@linaro.org> | 2024-03-26 14:32:54 +0100 |
| commit | 5c5d00df67a33d3931c35d566329f3d90013732b (patch) | |
| tree | d83ae85656bcc1d6092fb1013a8b1f9bd0273882 /hw/smbios | |
| parent | d5866a7a4e5a4178ccab4ca19303ea09635e5fa4 (diff) | |
| download | qemu-5c5d00df67a33d3931c35d566329f3d90013732b.zip qemu-5c5d00df67a33d3931c35d566329f3d90013732b.tar.gz qemu-5c5d00df67a33d3931c35d566329f3d90013732b.tar.bz2 | |
hw/smbios: add stub for smbios_get_table_legacy()
QEMU build fails with
hw/i386/fw_cfg.c:74: undefined reference to `smbios_get_table_legacy'
when it's built with only 'microvm' enabled i.e. with config patch
+++ b/configs/devices/i386-softmmu/default.mak
@@ -26,7 +26,7 @@
# Boards:
#
-CONFIG_ISAPC=y
-CONFIG_I440FX=y
-CONFIG_Q35=y
+CONFIG_ISAPC=n
+CONFIG_I440FX=n
+CONFIG_Q35=n
It happens because I've fogotten/lost smbios_get_table_legacy() stub.
Fix it by adding missing stub as Philippe suggested.
Fixes: b42b0e4daaa5 "smbios: build legacy mode code only for 'pc' machine"
Reported-by: Michael Tokarev <mjt@tls.msk.ru>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Message-ID: <20240326122630.85989-1-imammedo@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Diffstat (limited to 'hw/smbios')
| -rw-r--r-- | hw/smbios/smbios_legacy_stub.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/hw/smbios/smbios_legacy_stub.c b/hw/smbios/smbios_legacy_stub.c index f29b153..7d593dc 100644 --- a/hw/smbios/smbios_legacy_stub.c +++ b/hw/smbios/smbios_legacy_stub.c @@ -13,3 +13,8 @@ void smbios_add_usr_blob_size(size_t size) { } + +uint8_t *smbios_get_table_legacy(size_t *length, Error **errp) +{ + g_assert_not_reached(); +} |