diff options
| author | Philippe Mathieu-Daudé <f4bug@amsat.org> | 2020-07-07 06:12:58 +0200 |
|---|---|---|
| committer | Philippe Mathieu-Daudé <f4bug@amsat.org> | 2020-10-26 00:36:52 +0100 |
| commit | 692fb0ef31af680632c84bc18bc639cba4a0e24b (patch) | |
| tree | e23273507f41e3c41b36b779356d0d6c436ad31d /hw/sd | |
| parent | aecaa05922bca8b1760cd463935ca2a71df776f5 (diff) | |
| download | qemu-692fb0ef31af680632c84bc18bc639cba4a0e24b.zip qemu-692fb0ef31af680632c84bc18bc639cba4a0e24b.tar.gz qemu-692fb0ef31af680632c84bc18bc639cba4a0e24b.tar.bz2 | |
hw/sd/sdcard: Make iolen unsigned
I/O request length can not be negative.
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Message-Id: <20200630133912.9428-15-f4bug@amsat.org>
Diffstat (limited to 'hw/sd')
| -rw-r--r-- | hw/sd/sd.c | 2 | ||||
| -rw-r--r-- | hw/sd/trace-events | 2 |
2 files changed, 2 insertions, 2 deletions
@@ -1982,7 +1982,7 @@ uint8_t sd_read_byte(SDState *sd) { /* TODO: Append CRCs */ uint8_t ret; - int io_len; + uint32_t io_len; if (!sd->blk || !blk_is_inserted(sd->blk) || !sd->enable) return 0x00; diff --git a/hw/sd/trace-events b/hw/sd/trace-events index 96c7ea5..4140e48 100644 --- a/hw/sd/trace-events +++ b/hw/sd/trace-events @@ -52,7 +52,7 @@ sdcard_unlock(void) "" sdcard_read_block(uint64_t addr, uint32_t len) "addr 0x%" PRIx64 " size 0x%x" sdcard_write_block(uint64_t addr, uint32_t len) "addr 0x%" PRIx64 " size 0x%x" sdcard_write_data(const char *proto, const char *cmd_desc, uint8_t cmd, uint8_t value) "%s %20s/ CMD%02d value 0x%02x" -sdcard_read_data(const char *proto, const char *cmd_desc, uint8_t cmd, int length) "%s %20s/ CMD%02d len %d" +sdcard_read_data(const char *proto, const char *cmd_desc, uint8_t cmd, uint32_t length) "%s %20s/ CMD%02d len %" PRIu32 sdcard_set_voltage(uint16_t millivolts) "%u mV" # milkymist-memcard.c |