diff options
| author | Philippe Mathieu-Daudé <philmd@redhat.com> | 2021-12-18 12:19:12 +0100 |
|---|---|---|
| committer | Laurent Vivier <laurent@vivier.eu> | 2022-01-18 12:32:16 +0100 |
| commit | 2a0c51366985890e3bf6f41a48f3cb2dfe2f153e (patch) | |
| tree | 3344c7b4071a150aea4b306ea204e4fed596c17d /hw/scsi | |
| parent | 6446a79e10bf4482f67a8576aed1afd88cf964b1 (diff) | |
| download | qemu-2a0c51366985890e3bf6f41a48f3cb2dfe2f153e.zip qemu-2a0c51366985890e3bf6f41a48f3cb2dfe2f153e.tar.gz qemu-2a0c51366985890e3bf6f41a48f3cb2dfe2f153e.tar.bz2 | |
hw/scsi/megasas: Simplify using the ldst API
This code is easier to review using the load/store API.
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20211218111912.1499377-1-philmd@redhat.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
Diffstat (limited to 'hw/scsi')
| -rw-r--r-- | hw/scsi/megasas.c | 17 |
1 files changed, 3 insertions, 14 deletions
diff --git a/hw/scsi/megasas.c b/hw/scsi/megasas.c index dc9bbdb..83c321e 100644 --- a/hw/scsi/megasas.c +++ b/hw/scsi/megasas.c @@ -383,8 +383,7 @@ static int megasas_setup_inquiry(uint8_t *cdb, int pg, int len) cdb[1] = 0x1; cdb[2] = pg; } - cdb[3] = (len >> 8) & 0xff; - cdb[4] = (len & 0xff); + stw_be_p(&cdb[3], len); return len; } @@ -400,18 +399,8 @@ static void megasas_encode_lba(uint8_t *cdb, uint64_t lba, } else { cdb[0] = READ_16; } - cdb[2] = (lba >> 56) & 0xff; - cdb[3] = (lba >> 48) & 0xff; - cdb[4] = (lba >> 40) & 0xff; - cdb[5] = (lba >> 32) & 0xff; - cdb[6] = (lba >> 24) & 0xff; - cdb[7] = (lba >> 16) & 0xff; - cdb[8] = (lba >> 8) & 0xff; - cdb[9] = (lba) & 0xff; - cdb[10] = (len >> 24) & 0xff; - cdb[11] = (len >> 16) & 0xff; - cdb[12] = (len >> 8) & 0xff; - cdb[13] = (len) & 0xff; + stq_be_p(&cdb[2], lba); + stl_be_p(&cdb[2 + 8], len); } /* |