diff options
| author | Cédric Le Goater <clg@kaod.org> | 2021-11-02 17:29:05 +0100 |
|---|---|---|
| committer | David Gibson <david@gibson.dropbear.id.au> | 2021-11-09 10:32:52 +1100 |
| commit | 957c52aed5efcf036affb30907514262643f556a (patch) | |
| tree | 874ed43827c848ea155ce3291409699b01223a23 /hw/ppc | |
| parent | a23297479cc07812526fb6d9d213392dba555145 (diff) | |
| download | qemu-957c52aed5efcf036affb30907514262643f556a.zip qemu-957c52aed5efcf036affb30907514262643f556a.tar.gz qemu-957c52aed5efcf036affb30907514262643f556a.tar.bz2 | |
ppc/pnv: Fix check on block device before updating drive contents
Test is wrong and the backend can never updated. It could have led to
a QEMU crash but since the firmware deactivates flash access if a valid
layout is not detected, it went unnoticed.
Reported-by: Coverity CID 1465223
Fixes: 35dde5766211 ("ppc/pnv: Add a PNOR model")
Signed-off-by: Cédric Le Goater <clg@kaod.org>
Message-Id: <20211102162905.762078-1-clg@kaod.org>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Diffstat (limited to 'hw/ppc')
| -rw-r--r-- | hw/ppc/pnv_pnor.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/hw/ppc/pnv_pnor.c b/hw/ppc/pnv_pnor.c index 5ef1cf2..83ecccc 100644 --- a/hw/ppc/pnv_pnor.c +++ b/hw/ppc/pnv_pnor.c @@ -36,7 +36,7 @@ static void pnv_pnor_update(PnvPnor *s, int offset, int size) int offset_end; int ret; - if (s->blk) { + if (!s->blk || !blk_is_writable(s->blk)) { return; } |