diff options
| author | Bin Meng <bin.meng@windriver.com> | 2021-03-11 16:16:08 +0800 |
|---|---|---|
| committer | David Gibson <david@gibson.dropbear.id.au> | 2021-03-31 11:10:50 +1100 |
| commit | 093256789aaec8b9e84b620a4334adcea5992223 (patch) | |
| tree | 0e149857bd22f820940ce194997c89bfadd61b84 /hw/ppc | |
| parent | 6d40ce00c1166c317e298ad82ecf10e650c4f87d (diff) | |
| download | qemu-093256789aaec8b9e84b620a4334adcea5992223.zip qemu-093256789aaec8b9e84b620a4334adcea5992223.tar.gz qemu-093256789aaec8b9e84b620a4334adcea5992223.tar.bz2 | |
hw/ppc: e500: Add missing #address-cells and #size-cells in the eTSEC node
Per devicetree spec v0.3 [1] chapter 2.3.5:
The #address-cells and #size-cells properties are not inherited
from ancestors in the devicetree. They shall be explicitly defined.
If missing, a client program should assume a default value of 2
for #address-cells, and a value of 1 for #size-cells.
These properties are currently missing, causing the <reg> property
of the queue-group subnode to be incorrectly parsed using default
values.
[1] https://github.com/devicetree-org/devicetree-specification/releases/download/v0.3/devicetree-specification-v0.3.pdf
Fixes: fdfb7f2cdb2d ("e500: Add support for eTSEC in device tree")
Signed-off-by: Bin Meng <bin.meng@windriver.com>
Message-Id: <20210311081608.66891-1-bmeng.cn@gmail.com>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Diffstat (limited to 'hw/ppc')
| -rw-r--r-- | hw/ppc/e500.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/hw/ppc/e500.c b/hw/ppc/e500.c index 1d94485..79467ac 100644 --- a/hw/ppc/e500.c +++ b/hw/ppc/e500.c @@ -237,6 +237,8 @@ static int create_devtree_etsec(SysBusDevice *sbdev, PlatformDevtreeData *data) qemu_fdt_setprop_string(fdt, node, "model", "eTSEC"); qemu_fdt_setprop(fdt, node, "local-mac-address", etsec->conf.macaddr.a, 6); qemu_fdt_setprop_cells(fdt, node, "fixed-link", 0, 1, 1000, 0, 0); + qemu_fdt_setprop_cells(fdt, node, "#size-cells", 1); + qemu_fdt_setprop_cells(fdt, node, "#address-cells", 1); qemu_fdt_add_subnode(fdt, group); qemu_fdt_setprop_cells(fdt, group, "reg", mmio0, 0x1000); |