diff options
author | Philippe Mathieu-Daudé <philmd@redhat.com> | 2021-08-26 20:07:04 +0200 |
---|---|---|
committer | Peter Maydell <peter.maydell@linaro.org> | 2021-09-01 11:08:16 +0100 |
commit | 5dcf0d3ae2a5056b1ccdfc6e63ab18e5700d3ac8 (patch) | |
tree | 548e7f542c57f470c1fd41a1407621964a3a9c5b /hw/ppc/spapr_drc.c | |
parent | c0bb7d611403ba0fff050a6a065e76ab54d7ab77 (diff) | |
download | qemu-5dcf0d3ae2a5056b1ccdfc6e63ab18e5700d3ac8.zip qemu-5dcf0d3ae2a5056b1ccdfc6e63ab18e5700d3ac8.tar.gz qemu-5dcf0d3ae2a5056b1ccdfc6e63ab18e5700d3ac8.tar.bz2 |
hw/intc/arm_gicv3: Replace mis-used MEMTX_* constants by booleans
Quoting Peter Maydell:
These MEMTX_* aren't from the memory transaction API functions;
they're just being used by gicd_readl() and friends as a way to
indicate a success/failure so that the actual MemoryRegionOps
read/write fns like gicv3_dist_read() can log a guest error.
Arguably this is a bit of a misuse of the MEMTX_* constants and
perhaps we should have gicd_readl etc return a bool instead.
Follow his suggestion and replace the MEMTX_* constants by
boolean values, simplifying a bit the gicv3_dist_read() /
gicv3_dist_write() handlers.
Suggested-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-id: 20210826180704.2131949-3-philmd@redhat.com
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Diffstat (limited to 'hw/ppc/spapr_drc.c')
0 files changed, 0 insertions, 0 deletions