diff options
| author | Richard Henderson <richard.henderson@linaro.org> | 2020-11-03 13:20:21 -0800 |
|---|---|---|
| committer | Richard Henderson <richard.henderson@linaro.org> | 2020-11-04 10:35:40 -0800 |
| commit | c56caea3b2a4ef5d760266f554df0d92c5a45f87 (patch) | |
| tree | 80fba4ec72139128960a1bbe052dc8432c0d8e83 /hw/ppc/spapr.c | |
| parent | f14bed3fd4a17e1255e2ed6db1dfe50e654e601d (diff) | |
| download | qemu-c56caea3b2a4ef5d760266f554df0d92c5a45f87.zip qemu-c56caea3b2a4ef5d760266f554df0d92c5a45f87.tar.gz qemu-c56caea3b2a4ef5d760266f554df0d92c5a45f87.tar.bz2 | |
tcg: Revert "tcg/optimize: Flush data at labels not TCG_OPF_BB_END"
This reverts commit cd0372c515c4732d8bd3777cdd995c139c7ed7ea.
The patch is incorrect in that it retains copies between globals and
non-local temps, and non-local temps still die at the end of the BB.
Failing test case for hppa:
.globl _start
_start:
cmpiclr,= 0x24,%r19,%r0
cmpiclr,<> 0x2f,%r19,%r19
---- 00010057 0001005b
movi_i32 tmp0,$0x24
sub_i32 tmp1,tmp0,r19
mov_i32 tmp2,tmp0
mov_i32 tmp3,r19
movi_i32 tmp1,$0x0
---- 0001005b 0001005f
brcond_i32 tmp2,tmp3,eq,$L1
movi_i32 tmp0,$0x2f
sub_i32 tmp1,tmp0,r19
mov_i32 tmp2,tmp0
mov_i32 tmp3,r19
movi_i32 tmp1,$0x0
mov_i32 r19,tmp1
setcond_i32 psw_n,tmp2,tmp3,ne
set_label $L1
In this case, both copies of "mov_i32 tmp3,r19" are removed. The
second because opt thought it was redundant. The first is removed
later by liveness because tmp3 is known to be dead. This leaves
the setcond_i32 with an uninitialized input.
Revert the entire patch for 5.2, and a proper optimization across
the branch may be considered for the next development cycle.
Reported-by: qemu@igor2.repo.hu
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Diffstat (limited to 'hw/ppc/spapr.c')
0 files changed, 0 insertions, 0 deletions