aboutsummaryrefslogtreecommitdiff
path: root/hw/pci
diff options
context:
space:
mode:
authorDavid Gibson <david@gibson.dropbear.id.au>2019-04-24 14:19:57 +1000
committerMichael S. Tsirkin <mst@redhat.com>2019-05-20 18:40:02 -0400
commitc76efd7225d33b48f7a1dd4519620f0b50267612 (patch)
tree02d3ab9fa12225468d1b419573e3b73826378c61 /hw/pci
parentacbd487ddb36499108d3bc2fb0654f6892177633 (diff)
downloadqemu-c76efd7225d33b48f7a1dd4519620f0b50267612.zip
qemu-c76efd7225d33b48f7a1dd4519620f0b50267612.tar.gz
qemu-c76efd7225d33b48f7a1dd4519620f0b50267612.tar.bz2
pcie: Remove redundant test in pcie_mmcfg_data_{read,write}()
These functions have an explicit test for accesses above the device's config size. But pci_host_config_{read,write}_common() which they're about to call already have checks against the config space limit and do the right thing. So, remove the redundant tests. Signed-off-by: David Gibson <david@gibson.dropbear.id.au> Message-Id: <20190424041959.4087-2-david@gibson.dropbear.id.au>
Diffstat (limited to 'hw/pci')
-rw-r--r--hw/pci/pcie_host.c10
1 files changed, 0 insertions, 10 deletions
diff --git a/hw/pci/pcie_host.c b/hw/pci/pcie_host.c
index 553db56..1ee4945 100644
--- a/hw/pci/pcie_host.c
+++ b/hw/pci/pcie_host.c
@@ -47,11 +47,6 @@ static void pcie_mmcfg_data_write(void *opaque, hwaddr mmcfg_addr,
}
addr = PCIE_MMCFG_CONFOFFSET(mmcfg_addr);
limit = pci_config_size(pci_dev);
- if (limit <= addr) {
- /* conventional pci device can be behind pcie-to-pci bridge.
- 256 <= addr < 4K has no effects. */
- return;
- }
pci_host_config_write_common(pci_dev, addr, limit, val, len);
}
@@ -70,11 +65,6 @@ static uint64_t pcie_mmcfg_data_read(void *opaque,
}
addr = PCIE_MMCFG_CONFOFFSET(mmcfg_addr);
limit = pci_config_size(pci_dev);
- if (limit <= addr) {
- /* conventional pci device can be behind pcie-to-pci bridge.
- 256 <= addr < 4K has no effects. */
- return ~0x0;
- }
return pci_host_config_read_common(pci_dev, addr, limit, len);
}