aboutsummaryrefslogtreecommitdiff
path: root/hw/pci-host
diff options
context:
space:
mode:
authorMark Cave-Ayland <mark.cave-ayland@ilande.co.uk>2020-09-26 15:02:16 +0100
committerMark Cave-Ayland <mark.cave-ayland@ilande.co.uk>2020-10-28 07:59:25 +0000
commite237e1c2985e705155bf23390c80f4d2fa245742 (patch)
treea63fd7b42336d1efb1ef134ce5f2b13233b8921a /hw/pci-host
parentc4210bc17d5a78e63c3ed28049d70d2bf2261783 (diff)
downloadqemu-e237e1c2985e705155bf23390c80f4d2fa245742.zip
qemu-e237e1c2985e705155bf23390c80f4d2fa245742.tar.gz
qemu-e237e1c2985e705155bf23390c80f4d2fa245742.tar.bz2
sabre: don't call sysbus_mmio_map() in sabre_realize()
The device should not map itself but instead should be mapped to sysbus by the sun4u machine. Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org> Message-Id: <20200926140216.7368-7-mark.cave-ayland@ilande.co.uk> Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Diffstat (limited to 'hw/pci-host')
-rw-r--r--hw/pci-host/sabre.c8
1 files changed, 0 insertions, 8 deletions
diff --git a/hw/pci-host/sabre.c b/hw/pci-host/sabre.c
index 5ac6283..5394ad5 100644
--- a/hw/pci-host/sabre.c
+++ b/hw/pci-host/sabre.c
@@ -378,16 +378,8 @@ static void sabre_realize(DeviceState *dev, Error **errp)
{
SabreState *s = SABRE(dev);
PCIHostState *phb = PCI_HOST_BRIDGE(dev);
- SysBusDevice *sbd = SYS_BUS_DEVICE(s);
PCIDevice *pci_dev;
- /* sabre_config */
- sysbus_mmio_map(sbd, 0, s->special_base);
- /* PCI configuration space */
- sysbus_mmio_map(sbd, 1, s->special_base + 0x1000000ULL);
- /* pci_ioport */
- sysbus_mmio_map(sbd, 2, s->special_base + 0x2000000ULL);
-
memory_region_init(&s->pci_mmio, OBJECT(s), "pci-mmio", 0x100000000ULL);
memory_region_add_subregion(get_system_memory(), s->mem_base,
&s->pci_mmio);