aboutsummaryrefslogtreecommitdiff
path: root/hw/pci-host
diff options
context:
space:
mode:
authorBALATON Zoltan <balaton@eik.bme.hu>2021-07-12 15:11:01 +0200
committerDavid Gibson <david@gibson.dropbear.id.au>2021-07-13 10:12:17 +1000
commitc785a40179b10ce2d7a4afdb04f63c98d53a1756 (patch)
tree3aa5482f6af5cae8a72ba1897504faa40f1888c1 /hw/pci-host
parentd01e8dcf2749e3a3bb6e4690492bedd259784ca5 (diff)
downloadqemu-c785a40179b10ce2d7a4afdb04f63c98d53a1756.zip
qemu-c785a40179b10ce2d7a4afdb04f63c98d53a1756.tar.gz
qemu-c785a40179b10ce2d7a4afdb04f63c98d53a1756.tar.bz2
mv64361: Remove extra break from a switch case
The switch case of writing PCI 1 IO base address had an extra break statement that made part of the code unreachable. This did not cause a problem as guests ususally leave this register at its default value. Fixes: dcdf98a9015 ("Add emulation of Marvell MV64361 PPC system controller") Reported-by: Coverity (CID 1458135) Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu> Message-Id: <20210712131259.B705B7456E3@zero.eik.bme.hu> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Diffstat (limited to 'hw/pci-host')
-rw-r--r--hw/pci-host/mv64361.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/hw/pci-host/mv64361.c b/hw/pci-host/mv64361.c
index 20510d8..92b0f5d 100644
--- a/hw/pci-host/mv64361.c
+++ b/hw/pci-host/mv64361.c
@@ -687,7 +687,6 @@ static void mv64361_write(void *opaque, hwaddr addr, uint64_t val,
case MV64340_PCI_1_IO_BASE_ADDR:
s->pci[1].io_base = val & 0x30fffffULL;
warn_swap_bit(val);
- break;
if (!(s->cpu_conf & BIT(27))) {
s->pci[1].remap[4] = (val & 0xffffULL) << 16;
}