aboutsummaryrefslogtreecommitdiff
path: root/hw/pci-host
diff options
context:
space:
mode:
authorRichard Henderson <richard.henderson@linaro.org>2021-07-12 20:04:37 +0000
committerRichard Henderson <richard.henderson@linaro.org>2021-07-26 07:07:07 -1000
commit984178d86b92be23b0efb6da769f22adb08cb83a (patch)
tree09a35e9538f9da4e42790917f35933ccb0bd24b1 /hw/pci-host
parent2d758274ee477a96ba35ba05fe2e393c208e724b (diff)
downloadqemu-984178d86b92be23b0efb6da769f22adb08cb83a.zip
qemu-984178d86b92be23b0efb6da769f22adb08cb83a.tar.gz
qemu-984178d86b92be23b0efb6da769f22adb08cb83a.tar.bz2
hw/pci-hist/pnv_phb4: Fix typo in pnv_phb4_ioda_write
From clang-13: hw/pci-host/pnv_phb4.c:375:18: error: variable 'v' set but not used \ [-Werror,-Wunused-but-set-variable] It's pretty clear that we meant to write back 'v' after all that computation and not 'val'. Acked-by: David Gibson <david@gibson.dropbear.id.au> Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org> Reviewed-by: Cédric Le Goater <clg@kaod.org> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Diffstat (limited to 'hw/pci-host')
-rw-r--r--hw/pci-host/pnv_phb4.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/hw/pci-host/pnv_phb4.c b/hw/pci-host/pnv_phb4.c
index 54f57c6..5c375a9 100644
--- a/hw/pci-host/pnv_phb4.c
+++ b/hw/pci-host/pnv_phb4.c
@@ -392,7 +392,7 @@ static void pnv_phb4_ioda_write(PnvPHB4 *phb, uint64_t val)
v &= 0xffffffffffff0000ull;
v |= 0x000000000000cfffull & val;
}
- *tptr = val;
+ *tptr = v;
break;
}
case IODA3_TBL_MBT: