diff options
| author | David Gibson <david@gibson.dropbear.id.au> | 2017-11-29 19:46:22 +1100 |
|---|---|---|
| committer | Michael S. Tsirkin <mst@redhat.com> | 2017-12-05 19:13:45 +0200 |
| commit | 1115ff6d268bba163a183e8d63cec6b687cc5fc7 (patch) | |
| tree | ab3898aee356a6a4cf02a84095a82a1f5e7f8875 /hw/pci-host/grackle.c | |
| parent | 4426f06102d31c4062957034edeb417f34c67885 (diff) | |
| download | qemu-1115ff6d268bba163a183e8d63cec6b687cc5fc7.zip qemu-1115ff6d268bba163a183e8d63cec6b687cc5fc7.tar.gz qemu-1115ff6d268bba163a183e8d63cec6b687cc5fc7.tar.bz2 | |
pci: Rename root bus initialization functions for clarity
pci_bus_init(), pci_bus_new_inplace(), pci_bus_new() and pci_register_bus()
are misleadingly named. They're not used for initializing *any* PCI bus,
but only for a root PCI bus.
Non-root buses - i.e. ones under a logical PCI to PCI bridge - are instead
created with a direct qbus_create_inplace() (see pci_bridge_initfn()).
This patch renames the functions to make it clear they're only used for
a root bus.
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Marcel Apfelbaum <marcel@redhat.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
Diffstat (limited to 'hw/pci-host/grackle.c')
| -rw-r--r-- | hw/pci-host/grackle.c | 14 |
1 files changed, 7 insertions, 7 deletions
diff --git a/hw/pci-host/grackle.c b/hw/pci-host/grackle.c index 38cd279..3caf1cc 100644 --- a/hw/pci-host/grackle.c +++ b/hw/pci-host/grackle.c @@ -82,13 +82,13 @@ PCIBus *pci_grackle_init(uint32_t base, qemu_irq *pic, memory_region_add_subregion(address_space_mem, 0x80000000ULL, &d->pci_hole); - phb->bus = pci_register_bus(dev, NULL, - pci_grackle_set_irq, - pci_grackle_map_irq, - pic, - &d->pci_mmio, - address_space_io, - 0, 4, TYPE_PCI_BUS); + phb->bus = pci_register_root_bus(dev, NULL, + pci_grackle_set_irq, + pci_grackle_map_irq, + pic, + &d->pci_mmio, + address_space_io, + 0, 4, TYPE_PCI_BUS); pci_create_simple(phb->bus, 0, "grackle"); qdev_init_nofail(dev); |