diff options
| author | Zhao Liu <zhao1.liu@intel.com> | 2024-04-18 18:04:33 +0800 |
|---|---|---|
| committer | Philippe Mathieu-Daudé <philmd@linaro.org> | 2024-04-25 12:48:12 +0200 |
| commit | e0ddabc6d4cfef4a5c7f154f0b0ad00dbf9a18d0 (patch) | |
| tree | f846f108e6961b91f994551cf4f2643001f9e9b6 /hw/pci-bridge/cxl_upstream.c | |
| parent | a133d207a8fefe934eb808c2b1ee8f2c695cb528 (diff) | |
| download | qemu-e0ddabc6d4cfef4a5c7f154f0b0ad00dbf9a18d0.zip qemu-e0ddabc6d4cfef4a5c7f154f0b0ad00dbf9a18d0.tar.gz qemu-e0ddabc6d4cfef4a5c7f154f0b0ad00dbf9a18d0.tar.bz2 | |
hw/cxl/cxl-cdat: Make cxl_doe_cdat_init() return boolean
As error.h suggested, the best practice for callee is to return
something to indicate success / failure.
With returned boolean, there's no need to dereference @errp to check
failure case.
Suggested-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Message-ID: <20240418100433.1085447-4-zhao1.liu@linux.intel.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Diffstat (limited to 'hw/pci-bridge/cxl_upstream.c')
| -rw-r--r-- | hw/pci-bridge/cxl_upstream.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/hw/pci-bridge/cxl_upstream.c b/hw/pci-bridge/cxl_upstream.c index 783fa6a..e51221a 100644 --- a/hw/pci-bridge/cxl_upstream.c +++ b/hw/pci-bridge/cxl_upstream.c @@ -338,8 +338,7 @@ static void cxl_usp_realize(PCIDevice *d, Error **errp) cxl_cstate->cdat.build_cdat_table = build_cdat_table; cxl_cstate->cdat.free_cdat_table = free_default_cdat_table; cxl_cstate->cdat.private = d; - cxl_doe_cdat_init(cxl_cstate, errp); - if (*errp) { + if (!cxl_doe_cdat_init(cxl_cstate, errp)) { goto err_cap; } |