diff options
| author | Markus Armbruster <armbru@redhat.com> | 2019-08-12 07:23:50 +0200 |
|---|---|---|
| committer | Markus Armbruster <armbru@redhat.com> | 2019-08-16 13:31:52 +0200 |
| commit | db725815985654007ade0fd53590d613fd657208 (patch) | |
| tree | e39bcf77a808fa0002cea415b2a487cf5c7eaf4b /hw/net | |
| parent | dc5e9ac716c5c5312ab29fb9f311f8176064fe04 (diff) | |
| download | qemu-db725815985654007ade0fd53590d613fd657208.zip qemu-db725815985654007ade0fd53590d613fd657208.tar.gz qemu-db725815985654007ade0fd53590d613fd657208.tar.bz2 | |
Include qemu/main-loop.h less
In my "build everything" tree, changing qemu/main-loop.h triggers a
recompile of some 5600 out of 6600 objects (not counting tests and
objects that don't depend on qemu/osdep.h). It includes block/aio.h,
which in turn includes qemu/event_notifier.h, qemu/notify.h,
qemu/processor.h, qemu/qsp.h, qemu/queue.h, qemu/thread-posix.h,
qemu/thread.h, qemu/timer.h, and a few more.
Include qemu/main-loop.h only where it's needed. Touching it now
recompiles only some 1700 objects. For block/aio.h and
qemu/event_notifier.h, these numbers drop from 5600 to 2800. For the
others, they shrink only slightly.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20190812052359.30071-21-armbru@redhat.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Diffstat (limited to 'hw/net')
| -rw-r--r-- | hw/net/fsl_etsec/etsec.c | 1 | ||||
| -rw-r--r-- | hw/net/lan9118.c | 1 | ||||
| -rw-r--r-- | hw/net/vhost_net.c | 2 | ||||
| -rw-r--r-- | hw/net/virtio-net.c | 1 |
4 files changed, 4 insertions, 1 deletions
diff --git a/hw/net/fsl_etsec/etsec.c b/hw/net/fsl_etsec/etsec.c index e217238..e5c902a 100644 --- a/hw/net/fsl_etsec/etsec.c +++ b/hw/net/fsl_etsec/etsec.c @@ -34,6 +34,7 @@ #include "etsec.h" #include "registers.h" #include "qemu/log.h" +#include "qemu/main-loop.h" #include "qemu/module.h" /* #define HEX_DUMP */ diff --git a/hw/net/lan9118.c b/hw/net/lan9118.c index 1d32cb7..ea20a92 100644 --- a/hw/net/lan9118.c +++ b/hw/net/lan9118.c @@ -21,6 +21,7 @@ #include "sysemu/sysemu.h" #include "hw/ptimer.h" #include "qemu/log.h" +#include "qemu/main-loop.h" #include "qemu/module.h" /* For crc32 */ #include <zlib.h> diff --git a/hw/net/vhost_net.c b/hw/net/vhost_net.c index a6b7190..e975700 100644 --- a/hw/net/vhost_net.c +++ b/hw/net/vhost_net.c @@ -22,7 +22,7 @@ #include "hw/virtio/virtio-net.h" #include "net/vhost_net.h" #include "qemu/error-report.h" - +#include "qemu/main-loop.h" #include <sys/socket.h> #include <net/if.h> diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c index b9e1cd7..cdf4d77 100644 --- a/hw/net/virtio-net.c +++ b/hw/net/virtio-net.c @@ -13,6 +13,7 @@ #include "qemu/osdep.h" #include "qemu/iov.h" +#include "qemu/main-loop.h" #include "qemu/module.h" #include "hw/virtio/virtio.h" #include "net/net.h" |