diff options
| author | Li Qiang <liqiang6-s@360.cn> | 2016-08-16 16:58:01 +0530 |
|---|---|---|
| committer | Jason Wang <jasowang@redhat.com> | 2016-08-18 12:05:18 +0800 |
| commit | 47882fa4975bf0b58dd74474329fdd7154e8f04c (patch) | |
| tree | 72402d35a99e59a465b3a816eb5c10965bccd9fb /hw/net | |
| parent | 5f0e775348082c355769a3df612e055abea61c06 (diff) | |
| download | qemu-47882fa4975bf0b58dd74474329fdd7154e8f04c.zip qemu-47882fa4975bf0b58dd74474329fdd7154e8f04c.tar.gz qemu-47882fa4975bf0b58dd74474329fdd7154e8f04c.tar.bz2 | |
net: vmxnet: use g_new for pkt initialisation
When network transport abstraction layer initialises pkt, the maximum
fragmentation count is not checked. This could lead to an integer
overflow causing a NULL pointer dereference. Replace g_malloc() with
g_new() to catch the multiplication overflow.
Reported-by: Li Qiang <liqiang6-s@360.cn>
Signed-off-by: Prasad J Pandit <pjp@fedoraproject.org>
Acked-by: Dmitry Fleytman <dmitry@daynix.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
Diffstat (limited to 'hw/net')
| -rw-r--r-- | hw/net/net_tx_pkt.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/hw/net/net_tx_pkt.c b/hw/net/net_tx_pkt.c index 53dfaa2..20b2549 100644 --- a/hw/net/net_tx_pkt.c +++ b/hw/net/net_tx_pkt.c @@ -65,10 +65,9 @@ void net_tx_pkt_init(struct NetTxPkt **pkt, PCIDevice *pci_dev, p->pci_dev = pci_dev; - p->vec = g_malloc((sizeof *p->vec) * - (max_frags + NET_TX_PKT_PL_START_FRAG)); + p->vec = g_new(struct iovec, max_frags + NET_TX_PKT_PL_START_FRAG); - p->raw = g_malloc((sizeof *p->raw) * max_frags); + p->raw = g_new(struct iovec, max_frags); p->max_payload_frags = max_frags; p->max_raw_frags = max_frags; |