aboutsummaryrefslogtreecommitdiff
path: root/hw/net/rtl8139.c
diff options
context:
space:
mode:
authorPeter Maydell <peter.maydell@linaro.org>2024-08-01 10:15:03 +0100
committerPeter Maydell <peter.maydell@linaro.org>2024-08-01 10:15:03 +0100
commit55f9f4ee018c5ccea81d8c8c586756d7711ae46f (patch)
tree247d1bf104c937561d3d162e4061e616ba4a70d8 /hw/net/rtl8139.c
parent036144cff27ef2f97de7ffc0c1150f3779b94d58 (diff)
downloadqemu-55f9f4ee018c5ccea81d8c8c586756d7711ae46f.zip
qemu-55f9f4ee018c5ccea81d8c8c586756d7711ae46f.tar.gz
qemu-55f9f4ee018c5ccea81d8c8c586756d7711ae46f.tar.bz2
target/arm: Handle denormals correctly for FMOPA (widening)
The FMOPA (widening) SME instruction takes pairs of half-precision floating point values, widens them to single-precision, does a two-way dot product and accumulates the results into a single-precision destination. We don't quite correctly handle the FPCR bits FZ and FZ16 which control flushing of denormal inputs and outputs. This is because at the moment we pass a single float_status value to the helper function, which then uses that configuration for all the fp operations it does. However, because the inputs to this operation are float16 and the outputs are float32 we need to use the fp_status_f16 for the float16 input widening but the normal fp_status for everything else. Otherwise we will apply the flushing control FPCR.FZ16 to the 32-bit output rather than the FPCR.FZ control, and incorrectly flush a denormal output to zero when we should not (or vice-versa). (In commit 207d30b5fdb5b we tried to fix the FZ handling but didn't get it right, switching from "use FPCR.FZ for everything" to "use FPCR.FZ16 for everything".) Pass the CPU env to the sme_fmopa_h helper instead of an fp_status pointer, and have the helper pass an extra fp_status into the f16_dotadd() function so that we can use the right status for the right parts of this operation. Cc: qemu-stable@nongnu.org Fixes: 207d30b5fdb5 ("target/arm: Use FPST_F16 for SME FMOPA (widening)") Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2373 Signed-off-by: Peter Maydell <peter.maydell@linaro.org> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Diffstat (limited to 'hw/net/rtl8139.c')
0 files changed, 0 insertions, 0 deletions