diff options
author | Peter Maydell <peter.maydell@linaro.org> | 2023-04-06 16:59:46 +0100 |
---|---|---|
committer | Paolo Bonzini <pbonzini@redhat.com> | 2023-04-20 11:17:35 +0200 |
commit | 987b63f24afe027a09b1c549c05a032a477f7e96 (patch) | |
tree | 7f24ecc43341c27da30ec988deb14d776960b26f /hw/misc | |
parent | 8041e9e314819de9f54f3e267a0479e329561b96 (diff) | |
download | qemu-987b63f24afe027a09b1c549c05a032a477f7e96.zip qemu-987b63f24afe027a09b1c549c05a032a477f7e96.tar.gz qemu-987b63f24afe027a09b1c549c05a032a477f7e96.tar.bz2 |
target/i386: Avoid unreachable variable declaration in mmu_translate()
Coverity complains (CID 1507880) that the declaration "int error_code;"
in mmu_translate() is unreachable code. Since this is only a declaration,
this isn't actually a bug, but:
* it's a bear-trap for future changes, because if it was changed to
include an initialization 'int error_code = foo;' then the
initialization wouldn't actually happen (being dead code)
* it's against our coding style, which wants declarations to be
at the start of blocks
* it means that anybody reading the code has to go and look up
exactly what the C rules are for skipping over variable declarations
using a goto
Move the declaration to the top of the function.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Message-Id: <20230406155946.3362077-1-peter.maydell@linaro.org>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Diffstat (limited to 'hw/misc')
0 files changed, 0 insertions, 0 deletions