aboutsummaryrefslogtreecommitdiff
path: root/hw/misc/macio
diff options
context:
space:
mode:
authorBALATON Zoltan <balaton@eik.bme.hu>2025-02-22 13:28:50 +0100
committerPhilippe Mathieu-Daudé <philmd@linaro.org>2025-03-05 02:13:24 +0100
commit70f98ae150ab05e4807625878d271049af23716b (patch)
treed5d605feac9e63ef69953430a6b4ae1784618013 /hw/misc/macio
parent7fc96bc4fca0cd8f1733235e987fe8ccf4517203 (diff)
downloadqemu-70f98ae150ab05e4807625878d271049af23716b.zip
qemu-70f98ae150ab05e4807625878d271049af23716b.tar.gz
qemu-70f98ae150ab05e4807625878d271049af23716b.tar.bz2
hw/misc/macio: Improve trace logs
Add macio_gpio_read trace event and use that in macio_gpio_read() instead of macio_gpio_write. Also change log message to match macio_timer_{read,write}. Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu> Reviewed-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org> Message-ID: <20250222122850.9D8B84E603D@zero.eik.bme.hu> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Diffstat (limited to 'hw/misc/macio')
-rw-r--r--hw/misc/macio/gpio.c2
-rw-r--r--hw/misc/macio/trace-events3
2 files changed, 3 insertions, 2 deletions
diff --git a/hw/misc/macio/gpio.c b/hw/misc/macio/gpio.c
index 7cad628..4364afc 100644
--- a/hw/misc/macio/gpio.c
+++ b/hw/misc/macio/gpio.c
@@ -135,7 +135,7 @@ static uint64_t macio_gpio_read(void *opaque, hwaddr addr, unsigned size)
}
}
- trace_macio_gpio_write(addr, val);
+ trace_macio_gpio_read(addr, val);
return val;
}
diff --git a/hw/misc/macio/trace-events b/hw/misc/macio/trace-events
index ad4b9d1..055a407 100644
--- a/hw/misc/macio/trace-events
+++ b/hw/misc/macio/trace-events
@@ -18,7 +18,8 @@ macio_timer_read(uint64_t addr, unsigned len, uint32_t val) "read addr 0x%"PRIx6
macio_set_gpio(int gpio, bool state) "setting GPIO %d to %d"
macio_gpio_irq_assert(int gpio) "asserting GPIO %d"
macio_gpio_irq_deassert(int gpio) "deasserting GPIO %d"
-macio_gpio_write(uint64_t addr, uint64_t val) "addr: 0x%"PRIx64" value: 0x%"PRIx64
+macio_gpio_write(uint64_t addr, uint64_t val) "addr 0x%"PRIx64" val 0x%"PRIx64
+macio_gpio_read(uint64_t addr, uint64_t val) "addr 0x%"PRIx64" val 0x%"PRIx64
# pmu.c
pmu_adb_poll(int olen) "ADB autopoll, olen=%d"