diff options
author | Bharata B Rao <bharata@linux.vnet.ibm.com> | 2017-08-17 10:46:42 +0530 |
---|---|---|
committer | David Gibson <david@gibson.dropbear.id.au> | 2017-08-22 21:26:46 +1000 |
commit | 188bfe1b00360657c701cda2f97ce276add7e255 (patch) | |
tree | 7e19c4e47fcb0ecc8a479111590ee54abf2faabc /hw/isa | |
parent | 5dfaa532e0010c2dea50385c87683b0d756aa12f (diff) | |
download | qemu-188bfe1b00360657c701cda2f97ce276add7e255.zip qemu-188bfe1b00360657c701cda2f97ce276add7e255.tar.gz qemu-188bfe1b00360657c701cda2f97ce276add7e255.tar.bz2 |
spapr: Allow configure-connector to be called multiple times
In case of in-kernel memory hot unplug, when the guest is not able
to remove all the LMBs that are requested for removal, it will add back
any LMBs that have been successfully removed. The DR Connectors of
these LMBs wouldn't have been unconfigured and hence the addition of
these LMBs will result in configure-connector call being issued on
LMB DR connectors that are already in configured state. Such
configure-connector calls will fail resulting in a DIMM which is
partially unplugged.
This however worked till recently before we overhauled the DRC
implementation in QEMU. Commit 9d4c0f4f0a71e: "spapr: Consolidate
DRC state variables" is the first commit where this problem shows up
as per git bisect.
Ideally guest shouldn't be issuing configure-connector call on an
already configured DR connector. However for now, work around this in
QEMU by allowing configure-connector to be called multiple times for
all types of DR connectors.
Signed-off-by: Bharata B Rao <bharata@linux.vnet.ibm.com>
[dwg: Corrected buglet that would have initialized fdt pointers ready
for reading on a device not present at reset]
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Diffstat (limited to 'hw/isa')
0 files changed, 0 insertions, 0 deletions