aboutsummaryrefslogtreecommitdiff
path: root/hw/isa
diff options
context:
space:
mode:
authorThomas Huth <thuth@redhat.com>2017-09-13 11:07:17 +0200
committerMichael Tokarev <mjt@tls.msk.ru>2017-09-26 09:11:23 +0300
commit35deebb2327227d8c5f4816476befb06f6329de6 (patch)
treef85c904ebbdb3fd32da161cc9001943f4ec0e061 /hw/isa
parenta9b16ab368b623d00aaa3d55b0eafbf0e1fdde0b (diff)
downloadqemu-35deebb2327227d8c5f4816476befb06f6329de6.zip
qemu-35deebb2327227d8c5f4816476befb06f6329de6.tar.gz
qemu-35deebb2327227d8c5f4816476befb06f6329de6.tar.bz2
hw/isa/pc87312: Mark the device with user_creatable = false
QEMU currently aborts if you try to use the device at the command line: $ ppc64-softmmu/qemu-system-ppc64 -S -machine prep -device pc87312 Unexpected error in qemu_chr_fe_init() at chardev/char-fe.c:222: qemu-system-ppc64: -device pc87312: Device 'parallel0' is in use Aborted (core dumped) It uses parallel_hds in its realize function, so I can not be instantiated by the user again. Signed-off-by: Thomas Huth <thuth@redhat.com> Reviewed-by: Hervé Poussineau <hpoussin@reactos.org> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
Diffstat (limited to 'hw/isa')
-rw-r--r--hw/isa/pc87312.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/hw/isa/pc87312.c b/hw/isa/pc87312.c
index 5ce9f0a..48b29e3 100644
--- a/hw/isa/pc87312.c
+++ b/hw/isa/pc87312.c
@@ -386,6 +386,8 @@ static void pc87312_class_init(ObjectClass *klass, void *data)
dc->reset = pc87312_reset;
dc->vmsd = &vmstate_pc87312;
dc->props = pc87312_properties;
+ /* Reason: Uses parallel_hds[0] in realize(), so it can't be used twice */
+ dc->user_creatable = false;
}
static const TypeInfo pc87312_type_info = {