From 35deebb2327227d8c5f4816476befb06f6329de6 Mon Sep 17 00:00:00 2001 From: Thomas Huth Date: Wed, 13 Sep 2017 11:07:17 +0200 Subject: hw/isa/pc87312: Mark the device with user_creatable = false MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit QEMU currently aborts if you try to use the device at the command line: $ ppc64-softmmu/qemu-system-ppc64 -S -machine prep -device pc87312 Unexpected error in qemu_chr_fe_init() at chardev/char-fe.c:222: qemu-system-ppc64: -device pc87312: Device 'parallel0' is in use Aborted (core dumped) It uses parallel_hds in its realize function, so I can not be instantiated by the user again. Signed-off-by: Thomas Huth Reviewed-by: Hervé Poussineau Signed-off-by: Michael Tokarev --- hw/isa/pc87312.c | 2 ++ 1 file changed, 2 insertions(+) (limited to 'hw/isa') diff --git a/hw/isa/pc87312.c b/hw/isa/pc87312.c index 5ce9f0a..48b29e3 100644 --- a/hw/isa/pc87312.c +++ b/hw/isa/pc87312.c @@ -386,6 +386,8 @@ static void pc87312_class_init(ObjectClass *klass, void *data) dc->reset = pc87312_reset; dc->vmsd = &vmstate_pc87312; dc->props = pc87312_properties; + /* Reason: Uses parallel_hds[0] in realize(), so it can't be used twice */ + dc->user_creatable = false; } static const TypeInfo pc87312_type_info = { -- cgit v1.1