aboutsummaryrefslogtreecommitdiff
path: root/hw/ipmi
diff options
context:
space:
mode:
authorCorey Minyard <cminyard@mvista.com>2016-01-11 07:32:32 -0600
committerPaolo Bonzini <pbonzini@redhat.com>2016-02-09 15:46:54 +0100
commit37eebb8693368d890b700cca6e39ec31c7e980e5 (patch)
tree62cfca8da7c77083caae7c2e4affacad283ecd69 /hw/ipmi
parent93a5364620dbfcf3cc13866d0e218fc3624c1edf (diff)
downloadqemu-37eebb8693368d890b700cca6e39ec31c7e980e5.zip
qemu-37eebb8693368d890b700cca6e39ec31c7e980e5.tar.gz
qemu-37eebb8693368d890b700cca6e39ec31c7e980e5.tar.bz2
ipmi_bmc_sim: Add break to correct watchdog NMI check
It was falling through when it should have been a break. Found by Coverity. The logic could be simplified a bit with a fallthrough, probably the original thought, but that would be less clear, I think. Cc: Paolo Bonzini <pbonzini@redhat.com> Cc: Michael S. Tsirkin <mst@redhat.com> Cc: Peter Maydell <peter.maydell@linaro.org> Cc: Shannon Zhao <zhaoshenglong@huawei.com> Cc: Xiao Guangrong <guangrong.xiao@linux.intel.com> Cc: Stefan Hajnoczi <stefanha@redhat.com> Signed-off-by: Corey Minyard <cminyard@mvista.com> Message-Id: <1452519152-6500-3-git-send-email-minyard@acm.org> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Diffstat (limited to 'hw/ipmi')
-rw-r--r--hw/ipmi/ipmi_bmc_sim.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/hw/ipmi/ipmi_bmc_sim.c b/hw/ipmi/ipmi_bmc_sim.c
index b3796af..f8b2176 100644
--- a/hw/ipmi/ipmi_bmc_sim.c
+++ b/hw/ipmi/ipmi_bmc_sim.c
@@ -1135,6 +1135,8 @@ static void set_watchdog_timer(IPMIBmcSim *ibs,
rsp[2] = IPMI_CC_INVALID_DATA_FIELD;
return;
}
+ break;
+
default:
/* We don't support PRE_SMI */
rsp[2] = IPMI_CC_INVALID_DATA_FIELD;