diff options
| author | Philippe Mathieu-Daudé <f4bug@amsat.org> | 2020-06-02 13:44:34 +0100 |
|---|---|---|
| committer | Peter Maydell <peter.maydell@linaro.org> | 2020-06-05 17:23:08 +0100 |
| commit | 3a37f23979ac8179dd297b45cd23020a610002ef (patch) | |
| tree | cfe01312d77d29e45804b2f9871a44bea810279b /hw/input/pxa2xx_keypad.c | |
| parent | 6d686145c86c9712db1547f66bebb7131979c61b (diff) | |
| download | qemu-3a37f23979ac8179dd297b45cd23020a610002ef.zip qemu-3a37f23979ac8179dd297b45cd23020a610002ef.tar.gz qemu-3a37f23979ac8179dd297b45cd23020a610002ef.tar.bz2 | |
hw/input/pxa2xx_keypad: Replace hw_error() by qemu_log_mask()
hw_error() calls exit(). This a bit overkill when we can log
the accesses as unimplemented or guest error.
When fuzzing the devices, we don't want the whole process to
exit. Replace some hw_error() calls by qemu_log_mask()
(missed in commit 5a0001ec7e).
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-id: 20200525114123.21317-2-f4bug@amsat.org
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Diffstat (limited to 'hw/input/pxa2xx_keypad.c')
| -rw-r--r-- | hw/input/pxa2xx_keypad.c | 10 |
1 files changed, 7 insertions, 3 deletions
diff --git a/hw/input/pxa2xx_keypad.c b/hw/input/pxa2xx_keypad.c index 31862a7d..62aa6f6 100644 --- a/hw/input/pxa2xx_keypad.c +++ b/hw/input/pxa2xx_keypad.c @@ -12,7 +12,7 @@ */ #include "qemu/osdep.h" -#include "hw/hw.h" +#include "qemu/log.h" #include "hw/irq.h" #include "migration/vmstate.h" #include "hw/arm/pxa.h" @@ -233,7 +233,9 @@ static uint64_t pxa2xx_keypad_read(void *opaque, hwaddr offset, return s->kpkdi; break; default: - hw_error("%s: Bad offset " REG_FMT "\n", __func__, offset); + qemu_log_mask(LOG_GUEST_ERROR, + "%s: Bad read offset 0x%"HWADDR_PRIx"\n", + __func__, offset); } return 0; @@ -280,7 +282,9 @@ static void pxa2xx_keypad_write(void *opaque, hwaddr offset, break; default: - hw_error("%s: Bad offset " REG_FMT "\n", __func__, offset); + qemu_log_mask(LOG_GUEST_ERROR, + "%s: Bad write offset 0x%"HWADDR_PRIx"\n", + __func__, offset); } } |