diff options
author | Markus Armbruster <armbru@redhat.com> | 2022-11-21 09:50:53 +0100 |
---|---|---|
committer | Markus Armbruster <armbru@redhat.com> | 2022-12-14 16:19:35 +0100 |
commit | d1c81c34964193bc62167ee60bf70b203e763699 (patch) | |
tree | 702219e0294f547c703577e43bd88a3062785386 /hw/i386 | |
parent | f560eb1f0a73b786a9c306d453d9e2e846ecb3e7 (diff) | |
download | qemu-d1c81c34964193bc62167ee60bf70b203e763699.zip qemu-d1c81c34964193bc62167ee60bf70b203e763699.tar.gz qemu-d1c81c34964193bc62167ee60bf70b203e763699.tar.bz2 |
qapi: Use returned bool to check for failure (again)
Commit 012d4c96e2 changed the visitor functions taking Error ** to
return bool instead of void, and the commits following it used the new
return value to simplify error checking. Since then a few more uses
in need of the same treatment crept in. Do that. All pretty
mechanical except for
* balloon_stats_get_all()
This is basically the same transformation commit 012d4c96e2 applied
to the virtual walk example in include/qapi/visitor.h.
* set_max_queue_size()
Additionally replace "goto end of function" by return.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20221121085054.683122-10-armbru@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Diffstat (limited to 'hw/i386')
-rw-r--r-- | hw/i386/pc.c | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 546b703..fa69b6f 100644 --- a/hw/i386/pc.c +++ b/hw/i386/pc.c @@ -1782,12 +1782,9 @@ static void pc_machine_set_max_fw_size(Object *obj, Visitor *v, Error **errp) { PCMachineState *pcms = PC_MACHINE(obj); - Error *error = NULL; uint64_t value; - visit_type_size(v, name, &value, &error); - if (error) { - error_propagate(errp, error); + if (!visit_type_size(v, name, &value, errp)) { return; } |