diff options
| author | Corey Minyard <cminyard@mvista.com> | 2020-01-20 11:07:25 -0600 |
|---|---|---|
| committer | Michael S. Tsirkin <mst@redhat.com> | 2020-01-22 01:47:55 -0500 |
| commit | aefcaf9d1b3ebb30981627bd08f595211a648a62 (patch) | |
| tree | 14dfc55561f11d812d6a560e922d2231888e4c30 /hw/i386 | |
| parent | 76525114736e8f669766e69b715fa59ce8648aae (diff) | |
| download | qemu-aefcaf9d1b3ebb30981627bd08f595211a648a62.zip qemu-aefcaf9d1b3ebb30981627bd08f595211a648a62.tar.gz qemu-aefcaf9d1b3ebb30981627bd08f595211a648a62.tar.bz2 | |
i386:acpi: Remove _HID from the SMBus ACPI entry
Per the ACPI spec (version 6.1, section 6.1.5 _HID) it is not required
on enumerated buses (like PCI in this case), _ADR is required (and is
already there). And the _HID value is wrong. Linux appears to ignore
the _HID entry, but Windows 10 detects it as 'Unknown Device' and there
is no driver available. See https://bugs.launchpad.net/qemu/+bug/1856724
Signed-off-by: Corey Minyard <cminyard@mvista.com>
Cc: Michael S. Tsirkin <mst@redhat.com>
Cc: Igor Mammedov <imammedo@redhat.com>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
Message-Id: <20200120170725.24935-6-minyard@acm.org>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Diffstat (limited to 'hw/i386')
| -rw-r--r-- | hw/i386/acpi-build.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index e25df83..9c4e46f 100644 --- a/hw/i386/acpi-build.c +++ b/hw/i386/acpi-build.c @@ -1816,7 +1816,6 @@ static void build_smb0(Aml *table, I2CBus *smbus, int devnr, int func) Aml *scope = aml_scope("_SB.PCI0"); Aml *dev = aml_device("SMB0"); - aml_append(dev, aml_name_decl("_HID", aml_eisaid("APP0005"))); aml_append(dev, aml_name_decl("_ADR", aml_int(devnr << 16 | func))); build_acpi_ipmi_devices(dev, BUS(smbus), "\\_SB.PCI0.SMB0"); aml_append(scope, dev); |