diff options
| author | Philippe Mathieu-Daudé <philmd@linaro.org> | 2023-06-20 07:18:12 +0200 |
|---|---|---|
| committer | Philippe Mathieu-Daudé <philmd@linaro.org> | 2023-08-31 19:47:43 +0200 |
| commit | b797c98de4106b0d8cd1daa7d32f31e47e9f1d46 (patch) | |
| tree | 1588414dcf9add5f74bd9092a871a6a28abf259f /hw/i386/kvm | |
| parent | f8324611c1ec100fd601842d3943cbf8acd1420f (diff) | |
| download | qemu-b797c98de4106b0d8cd1daa7d32f31e47e9f1d46.zip qemu-b797c98de4106b0d8cd1daa7d32f31e47e9f1d46.tar.gz qemu-b797c98de4106b0d8cd1daa7d32f31e47e9f1d46.tar.bz2 | |
hw/i386: Remove unuseful kvmclock_create() stub
We shouldn't call kvmclock_create() when KVM is not available
or disabled:
- check for kvm_enabled() before calling it
- assert KVM is enabled once called
Since the call is elided when KVM is not available, we can
remove the stub (it is never compiled).
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20230620083228.88796-2-philmd@linaro.org>
Diffstat (limited to 'hw/i386/kvm')
| -rw-r--r-- | hw/i386/kvm/clock.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/hw/i386/kvm/clock.c b/hw/i386/kvm/clock.c index df70b4a..0824c6d 100644 --- a/hw/i386/kvm/clock.c +++ b/hw/i386/kvm/clock.c @@ -332,8 +332,10 @@ void kvmclock_create(bool create_always) { X86CPU *cpu = X86_CPU(first_cpu); - if (!kvm_enabled() || !kvm_has_adjust_clock()) + assert(kvm_enabled()); + if (!kvm_has_adjust_clock()) { return; + } if (create_always || cpu->env.features[FEAT_KVM] & ((1ULL << KVM_FEATURE_CLOCKSOURCE) | |