diff options
| author | Yicong Yang <yangyicong@hisilicon.com> | 2022-12-29 14:55:09 +0800 |
|---|---|---|
| committer | Michael S. Tsirkin <mst@redhat.com> | 2023-01-08 01:54:23 -0500 |
| commit | 97f4effeb6083f3c15f48cf4eea0c16552a9330a (patch) | |
| tree | d4f7132396ece858a2cf9c170da1ec54d4c2d52a /hw/core | |
| parent | 3cce48d333a6063b72c574c2b27a0f043ca02e33 (diff) | |
| download | qemu-97f4effeb6083f3c15f48cf4eea0c16552a9330a.zip qemu-97f4effeb6083f3c15f48cf4eea0c16552a9330a.tar.gz qemu-97f4effeb6083f3c15f48cf4eea0c16552a9330a.tar.bz2 | |
hw/acpi/aml-build: Only generate cluster node in PPTT when specified
Currently we'll always generate a cluster node no matter user has
specified '-smp clusters=X' or not. Cluster is an optional level
and will participant the building of Linux scheduling domains and
only appears on a few platforms. It's unncessary to always build
it when it cannot reflect the real topology on platforms having no
cluster implementation and to avoid affecting the linux scheduling
domains in the VM. So only generate the cluster topology in ACPI
PPTT when the user has specified it explicitly in -smp.
Tested qemu-system-aarch64 with `-smp 8` and linux 6.1-rc1, without
this patch:
estuary:/sys/devices/system/cpu/cpu0/topology$ cat cluster_*
ff # cluster_cpus
0-7 # cluster_cpus_list
56 # cluster_id
with this patch:
estuary:/sys/devices/system/cpu/cpu0/topology$ cat cluster_*
ff # cluster_cpus
0-7 # cluster_cpus_list
36 # cluster_id, with no cluster node kernel will make it to
physical package id
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Yanan Wang <wangyanan55@huawei.com>
Tested-by: Yanan Wang <wangyanan55@huawei.com>
Signed-off-by: Yicong Yang <yangyicong@hisilicon.com>
Message-Id: <20221229065513.55652-3-yangyicong@huawei.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Diffstat (limited to 'hw/core')
| -rw-r--r-- | hw/core/machine-smp.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/hw/core/machine-smp.c b/hw/core/machine-smp.c index b39ed21..c3dab00 100644 --- a/hw/core/machine-smp.c +++ b/hw/core/machine-smp.c @@ -158,6 +158,8 @@ void machine_parse_smp_config(MachineState *ms, ms->smp.threads = threads; ms->smp.max_cpus = maxcpus; + mc->smp_props.has_clusters = config->has_clusters; + /* sanity-check of the computed topology */ if (sockets * dies * clusters * cores * threads != maxcpus) { g_autofree char *topo_msg = cpu_hierarchy_to_string(ms); |