aboutsummaryrefslogtreecommitdiff
path: root/hw/char
diff options
context:
space:
mode:
authorMarkus Armbruster <armbru@redhat.com>2015-08-26 14:02:53 +0200
committerMichael Tokarev <mjt@tls.msk.ru>2015-09-11 10:21:38 +0300
commit012aef073461fd24a901d7a8742532093b7f6ae5 (patch)
tree4ee28d5cedea44f2af2b5b3a7fe482d9e80a3fad /hw/char
parentef1e1e0782e99c9dcf2b35e5310cdd8ca9211374 (diff)
downloadqemu-012aef073461fd24a901d7a8742532093b7f6ae5.zip
qemu-012aef073461fd24a901d7a8742532093b7f6ae5.tar.gz
qemu-012aef073461fd24a901d7a8742532093b7f6ae5.tar.bz2
maint: avoid useless "if (foo) free(foo)" pattern
My Coccinelle semantic patch finds a few more, because it also fixes up the equally pointless conditional if (foo) { free(foo); foo = NULL; } Result (feel free to squash it into your patch): Signed-off-by: Markus Armbruster <armbru@redhat.com> Reviewed-by: Eric Blake <eblake@redhat.com> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
Diffstat (limited to 'hw/char')
-rw-r--r--hw/char/exynos4210_uart.c6
1 files changed, 2 insertions, 4 deletions
diff --git a/hw/char/exynos4210_uart.c b/hw/char/exynos4210_uart.c
index 7614e58..215f962 100644
--- a/hw/char/exynos4210_uart.c
+++ b/hw/char/exynos4210_uart.c
@@ -234,10 +234,8 @@ static int fifo_empty_elements_number(Exynos4210UartFIFO *q)
static void fifo_reset(Exynos4210UartFIFO *q)
{
- if (q->data != NULL) {
- g_free(q->data);
- q->data = NULL;
- }
+ g_free(q->data);
+ q->data = NULL;
q->data = (uint8_t *)g_malloc0(q->size);