diff options
| author | Fam Zheng <famz@redhat.com> | 2015-02-16 12:09:40 +0800 |
|---|---|---|
| committer | Kevin Wolf <kwolf@redhat.com> | 2015-03-10 14:02:23 +0100 |
| commit | 4c0542ea60d21b56a9157d3f6331d2df8990d3bb (patch) | |
| tree | 415143ba5c0660c5844a86400cc77aeec52d8e58 /hw/block/virtio-blk.c | |
| parent | 9b7d2d8b076ff12f0d7b4246aec8f421b4150aae (diff) | |
| download | qemu-4c0542ea60d21b56a9157d3f6331d2df8990d3bb.zip qemu-4c0542ea60d21b56a9157d3f6331d2df8990d3bb.tar.gz qemu-4c0542ea60d21b56a9157d3f6331d2df8990d3bb.tar.bz2 | |
virtio-blk: Remove the stale FIXME comment
By default, we have ioeventfd enabled, so the IO request processing is
in IO thread; in the vcpu thread, guest mode is returned to as quickly
as possible, and completion is delivered via irqfd. Therefore this
comment from the initial implementation is barely relevant.
Signed-off-by: Fam Zheng <famz@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Diffstat (limited to 'hw/block/virtio-blk.c')
| -rw-r--r-- | hw/block/virtio-blk.c | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c index 2acfef8..0468297 100644 --- a/hw/block/virtio-blk.c +++ b/hw/block/virtio-blk.c @@ -597,12 +597,6 @@ static void virtio_blk_handle_output(VirtIODevice *vdev, VirtQueue *vq) if (mrb.num_reqs) { virtio_blk_submit_multireq(s->blk, &mrb); } - - /* - * FIXME: Want to check for completions before returning to guest mode, - * so cached reads and writes are reported as quickly as possible. But - * that should be done in the generic block layer. - */ } static void virtio_blk_dma_restart_bh(void *opaque) |