diff options
| author | BALATON Zoltan <balaton@eik.bme.hu> | 2020-07-05 19:22:11 +0200 |
|---|---|---|
| committer | Alistair Francis <alistair.francis@wdc.com> | 2020-09-25 16:52:08 -0700 |
| commit | 617160c9e1f8022563c33aa7fd204535d4d49f8c (patch) | |
| tree | 9bdc09357ec3690c71f21058d88bada7b977bb33 /hw/arm | |
| parent | 8d16e72f2d4df2c9e631393adf1669a1da7efe8a (diff) | |
| download | qemu-617160c9e1f8022563c33aa7fd204535d4d49f8c.zip qemu-617160c9e1f8022563c33aa7fd204535d4d49f8c.tar.gz qemu-617160c9e1f8022563c33aa7fd204535d4d49f8c.tar.bz2 | |
load_elf: Remove unused address variables from callers
Several callers of load_elf() pass pointers for lowaddr and highaddr
parameters which are then not used for anything. This may stem from a
misunderstanding that load_elf need a value here but in fact it can
take NULL to ignore these values. Remove such unused variables and
pass NULL instead from callers that don't need these.
Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Acked-by: David Gibson <david@gibson.dropbear.id.au>
Acked-by: Max Filippov <jcmvbkbc@gmail.com>
Message-Id: <20200705174020.BDD0174633F@zero.eik.bme.hu>
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
Diffstat (limited to 'hw/arm')
| -rw-r--r-- | hw/arm/armv7m.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/hw/arm/armv7m.c b/hw/arm/armv7m.c index 0e5997d..8113b29 100644 --- a/hw/arm/armv7m.c +++ b/hw/arm/armv7m.c @@ -292,7 +292,6 @@ void armv7m_load_kernel(ARMCPU *cpu, const char *kernel_filename, int mem_size) { int image_size; uint64_t entry; - uint64_t lowaddr; int big_endian; AddressSpace *as; int asidx; @@ -313,12 +312,11 @@ void armv7m_load_kernel(ARMCPU *cpu, const char *kernel_filename, int mem_size) if (kernel_filename) { image_size = load_elf_as(kernel_filename, NULL, NULL, NULL, - &entry, &lowaddr, NULL, + &entry, NULL, NULL, NULL, big_endian, EM_ARM, 1, 0, as); if (image_size < 0) { image_size = load_image_targphys_as(kernel_filename, 0, mem_size, as); - lowaddr = 0; } if (image_size < 0) { error_report("Could not load kernel '%s'", kernel_filename); |