diff options
| author | Peter Maydell <peter.maydell@linaro.org> | 2018-04-20 15:52:44 +0100 |
|---|---|---|
| committer | Peter Maydell <peter.maydell@linaro.org> | 2018-04-26 13:57:00 +0100 |
| commit | fc38a1120c2fabb76546ef8980e6d18b5fb7e843 (patch) | |
| tree | 3b58b52e56a00a7ac26ef416b88dd0a3ba8bf417 /hw/arm/fsl-imx6.c | |
| parent | 9bca0edb282de0007a4f068d9d20f3e3c3aadef7 (diff) | |
| download | qemu-fc38a1120c2fabb76546ef8980e6d18b5fb7e843.zip qemu-fc38a1120c2fabb76546ef8980e6d18b5fb7e843.tar.gz qemu-fc38a1120c2fabb76546ef8980e6d18b5fb7e843.tar.bz2 | |
Remove checks on MAX_SERIAL_PORTS that are just bounds checks
Remove checks on MAX_SERIAL_PORTS that were just checking whether
they were within bounds for the serial_hds[] array and falling
back to NULL if not. This isn't needed with the serial_hd()
function, which returns NULL for all indexes beyond what the
user set up.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-id: 20180420145249.32435-9-peter.maydell@linaro.org
Diffstat (limited to 'hw/arm/fsl-imx6.c')
| -rw-r--r-- | hw/arm/fsl-imx6.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/hw/arm/fsl-imx6.c b/hw/arm/fsl-imx6.c index 535ad58..4f51bd9 100644 --- a/hw/arm/fsl-imx6.c +++ b/hw/arm/fsl-imx6.c @@ -188,9 +188,7 @@ static void fsl_imx6_realize(DeviceState *dev, Error **errp) { FSL_IMX6_UART5_ADDR, FSL_IMX6_UART5_IRQ }, }; - if (i < MAX_SERIAL_PORTS) { - qdev_prop_set_chr(DEVICE(&s->uart[i]), "chardev", serial_hd(i)); - } + qdev_prop_set_chr(DEVICE(&s->uart[i]), "chardev", serial_hd(i)); object_property_set_bool(OBJECT(&s->uart[i]), true, "realized", &err); if (err) { |