aboutsummaryrefslogtreecommitdiff
path: root/hw/arm/digic.c
diff options
context:
space:
mode:
authorMarkus Armbruster <armbru@redhat.com>2021-11-17 17:33:59 +0100
committerMarkus Armbruster <armbru@redhat.com>2021-12-15 08:38:16 +0100
commit93d8bc8f5bc20a3108c9c9592d43d0202778f0c5 (patch)
tree9b59c77852b1682ccba08d849d6538bd6a1569c1 /hw/arm/digic.c
parent64eaa8209597a580c026d4891c072723a38ff0a6 (diff)
downloadqemu-93d8bc8f5bc20a3108c9c9592d43d0202778f0c5.zip
qemu-93d8bc8f5bc20a3108c9c9592d43d0202778f0c5.tar.gz
qemu-93d8bc8f5bc20a3108c9c9592d43d0202778f0c5.tar.bz2
hw/arm/npcm7xx_boards: Replace drive_get_next() by drive_get()
drive_get_next() is basically a bad idea. It returns the "next" block backend of a certain interface type. "Next" means bus=0,unit=N, where subsequent calls count N up from zero, per interface type. This lets you define unit numbers implicitly by execution order. If the order changes, or new calls appear "in the middle", unit numbers change. ABI break. Hard to spot in review. Machine "quanta-gbs-bmc" connects just one backend with drive_get_next(), but with a helper function. Change it to use drive_get() directly. This makes the unit numbers explicit in the code. Cc: Havard Skinnemoen <hskinnemoen@google.com> Cc: Tyrone Ting <kfting@nuvoton.com> Cc: Peter Maydell <peter.maydell@linaro.org> Cc: qemu-arm@nongnu.org Signed-off-by: Markus Armbruster <armbru@redhat.com> Message-Id: <20211117163409.3587705-4-armbru@redhat.com> Reviewed-by: Havard Skinnemoen <hskinnemoen@google.com>
Diffstat (limited to 'hw/arm/digic.c')
0 files changed, 0 insertions, 0 deletions