aboutsummaryrefslogtreecommitdiff
path: root/hw/arm/boot.c
diff options
context:
space:
mode:
authorIgor Mammedov <imammedo@redhat.com>2018-04-26 11:04:38 +0100
committerPeter Maydell <peter.maydell@linaro.org>2018-04-26 11:04:38 +0100
commit75ed2c02484101d5b4995c56e78a894ac244ce05 (patch)
tree251b18cfe6fe559e49bb699ff869445507143990 /hw/arm/boot.c
parent14ec3cbd7c1e31dca4d23f028100c8f43e156573 (diff)
downloadqemu-75ed2c02484101d5b4995c56e78a894ac244ce05.zip
qemu-75ed2c02484101d5b4995c56e78a894ac244ce05.tar.gz
qemu-75ed2c02484101d5b4995c56e78a894ac244ce05.tar.bz2
arm: always start from first_cpu when registering loader cpu reset callback
if arm_load_kernel() were passed non first_cpu, QEMU would end up with partially set do_cpu_reset() callback leaving some CPUs without it. Make sure that do_cpu_reset() is registered for all CPUs by enumerating CPUs from first_cpu. (In practice every board that we have was passing us the first CPU as the boot CPU, either directly or indirectly, so this wasn't causing incorrect behaviour.) Signed-off-by: Igor Mammedov <imammedo@redhat.com> Reviewed-by: Peter Maydell <peter.maydell@linaro.org> [PMM: added a note that this isn't a behaviour change] Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Diffstat (limited to 'hw/arm/boot.c')
-rw-r--r--hw/arm/boot.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/hw/arm/boot.c b/hw/arm/boot.c
index 26184bc..9ae6ab2 100644
--- a/hw/arm/boot.c
+++ b/hw/arm/boot.c
@@ -1188,7 +1188,7 @@ void arm_load_kernel(ARMCPU *cpu, struct arm_boot_info *info)
* actually loading a kernel, the handler is also responsible for
* arranging that we start it correctly.
*/
- for (cs = CPU(cpu); cs; cs = CPU_NEXT(cs)) {
+ for (cs = first_cpu; cs; cs = CPU_NEXT(cs)) {
qemu_register_reset(do_cpu_reset, ARM_CPU(cs));
}
}