diff options
author | Kevin Wolf <kwolf@redhat.com> | 2022-11-18 18:40:58 +0100 |
---|---|---|
committer | Kevin Wolf <kwolf@redhat.com> | 2022-12-15 16:07:42 +0100 |
commit | 5e8ac21717373cbe96ef7a91e216bf5788815d63 (patch) | |
tree | 3ceacec64b12c9c87fc8f568c5beb606fcedb6a6 /hmp-commands-info.hx | |
parent | 7bce1c299834557bffd92294608ea528648cfe75 (diff) | |
download | qemu-5e8ac21717373cbe96ef7a91e216bf5788815d63.zip qemu-5e8ac21717373cbe96ef7a91e216bf5788815d63.tar.gz qemu-5e8ac21717373cbe96ef7a91e216bf5788815d63.tar.bz2 |
block: Revert .bdrv_drained_begin/end to non-coroutine_fn
Polling during bdrv_drained_end() can be problematic (and in the future,
we may get cases for bdrv_drained_begin() where polling is forbidden,
and we don't care about already in-flight requests, but just want to
prevent new requests from arriving).
The .bdrv_drained_begin/end callbacks running in a coroutine is the only
reason why we have to do this polling, so make them non-coroutine
callbacks again. None of the callers actually yield any more.
This means that bdrv_drained_end() effectively doesn't poll any more,
even if AIO_WAIT_WHILE() loops are still there (their condition is false
from the beginning). This is generally not a problem, but in
test-bdrv-drain, some additional explicit aio_poll() calls need to be
added because the test case wants to verify the final state after BHs
have executed.
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Reviewed-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
Reviewed-by: Hanna Reitz <hreitz@redhat.com>
Message-Id: <20221118174110.55183-4-kwolf@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Diffstat (limited to 'hmp-commands-info.hx')
0 files changed, 0 insertions, 0 deletions